Skip to content

EZP-24138: Fix eZ Tags missing schema sql required for multilanguage postgresql support#92

Merged
emodric merged 1 commit intoezsystems:multilanguagefrom
brookinsconsulting:multilanguage-add-postgresql-support
May 4, 2015
Merged

EZP-24138: Fix eZ Tags missing schema sql required for multilanguage postgresql support#92
emodric merged 1 commit intoezsystems:multilanguagefrom
brookinsconsulting:multilanguage-add-postgresql-support

Conversation

@brookinsconsulting
Copy link
Contributor

Hello,

We noticed that the activity on PR #90 had gone stale for some time and since we have already been very active in that PR we wanted to step up and try to complete the work required.

This is the related issue ticket: https://jira.ez.no/browse/EZP-24138

This PR is specifically for the multilanguage branch. We have submitted another PR #91 for the required changes to the master branch as well.

This PR comes from the following share.ez.no forum conversation: http://share.ez.no/forums/install-configuration/migration-from-mysql-to-postgresql#comment85594

Please let us know what you think!

Cheers,
Brookins Consulting

@brookinsconsulting brookinsconsulting changed the title ZP-24138: Fix eZ Tags missing schema sql required for multilanguage postgresql support EZP-24138: Fix eZ Tags missing schema sql required for multilanguage postgresql support May 4, 2015
@emodric
Copy link
Collaborator

emodric commented May 4, 2015

Hi @brookinsconsulting,

Thanks for this :)

Two issues (again) :)

  1. CS fix: No new line at EOF

  2. eztags_keyword_s sequence is not needed, right? It's not being used in eztags_keyword table.

@brookinsconsulting brookinsconsulting force-pushed the multilanguage-add-postgresql-support branch from 87acde4 to 4c78c59 Compare May 4, 2015 09:57
@brookinsconsulting
Copy link
Contributor Author

Hello @emodric

We have addressed the two issues you mentioned and flattened.

Please let us know what you think.

Cheers,
Brookins Consulting

@emodric
Copy link
Collaborator

emodric commented May 4, 2015

Merging :)

Thanks @brookinsconsulting!

emodric added a commit that referenced this pull request May 4, 2015
…gresql-support

EZP-24138: Fix eZ Tags missing schema sql required for multilanguage postgresql support
@emodric emodric merged commit dccf3ce into ezsystems:multilanguage May 4, 2015
@brookinsconsulting
Copy link
Contributor Author

Hello @emodric

Thank you very much for your prompt review and merging!

The real thanks goes to @Ramna who did the real work and testing.

We just finished up the remaining PR work.

We are very happy that all of us can now say we have multilanguage postgresql support in eztags!

Thanks again. Take it eZ!

Cheers,
Brookins Consulting

@brookinsconsulting brookinsconsulting deleted the multilanguage-add-postgresql-support branch May 4, 2015 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments