Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-tty systems (CI) #52

Merged
merged 2 commits into from Sep 13, 2018
Merged

Conversation

hranicka
Copy link
Contributor

@hranicka hranicka commented Sep 3, 2018

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Fixed tickets -

I want to build an application in CI (Gitlab) with eZ Launchpad.

When I executed ~/ez docker:create, the script has failed:

$ ~/ez docker:create --no-interaction

In Process.php line 1042:
                                                   
  TTY mode requires /dev/tty to be read/writable.  

CI does not support TTY but it's required in the code except Windows platform. I've enhanced the condition to check not only the platform, but actual support of TTY.

Also this information is now propagated to Docker client which runs docker-compose exec -T on platform which does not support TTY. Without -T option, docker-compose exec allocated TTY by default and it would not work.

@hranicka hranicka force-pushed the feature/tty branch 3 times, most recently from 545b48f to a096a61 Compare September 3, 2018 09:31
@Plopix
Copy link
Collaborator

Plopix commented Sep 10, 2018

nice @hranicka ! I think I will merge. Unless you are telling me you are going to add the test soon. but that is a really nice improvement!

@hranicka
Copy link
Contributor Author

Hello @Plopix , sorry for delay. Now I've added tests :)

@Plopix Plopix merged commit d587963 into ezsystems:master Sep 13, 2018
@Plopix
Copy link
Collaborator

Plopix commented Sep 13, 2018

Awesome @hranicka Thanks a lot! ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants