New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-29104: Impl. ImageAsset field type #246

Merged
merged 8 commits into from Sep 11, 2018

Conversation

@adamwojs
Member

adamwojs commented Jul 26, 2018

JIRA: https://jira.ez.no/browse/EZP-29104
Depends on ezsystems/ezpublish-kernel#2403

Description

Impl. of \EzSystems\RepositoryForms\FieldType\FieldDefinitionFormMapperInterface and \EzSystems\RepositoryForms\FieldType\FieldValueFormMapperInterface for Image Asset Field Type.

@adamwojs adamwojs referenced this pull request Jul 26, 2018

Merged

EZP-29104: Implemented UI for ImageAsset Field Type #580

3 of 3 tasks complete

@adamwojs adamwojs changed the title from [WIP] EZP-29104: Impl. ImageAsset field type to EZP-29104: Impl. ImageAsset field type Jul 27, 2018

Show outdated Hide outdated lib/FieldType/DataTransformer/ImageAssetValueTransformer.php
Show outdated Hide outdated lib/FieldType/Mapper/ImageAssetFormMapper.php
class ImageAssetFieldType extends AbstractType
{
/** @var \eZ\Publish\API\Repository\ContentService */
private $contentService;

This comment was marked as resolved.

@webhdx

webhdx Jul 31, 2018

Contributor

Add empty lines between properties.

@webhdx

webhdx Jul 31, 2018

Contributor

Add empty lines between properties.

Show outdated Hide outdated lib/Form/Type/FieldType/ImageAssetFieldType.php
@adamwojs

This comment has been minimized.

Show comment
Hide comment
@adamwojs

adamwojs Aug 2, 2018

Member

PR updated according to @webhdx @mikadamczyk suggestions.

Member

adamwojs commented Aug 2, 2018

PR updated according to @webhdx @mikadamczyk suggestions.

@adamwojs

This comment has been minimized.

Show comment
Hide comment
@adamwojs

adamwojs Aug 3, 2018

Member

PR ready for the final code review @mikadamczyk @webhdx

Member

adamwojs commented Aug 3, 2018

PR ready for the final code review @mikadamczyk @webhdx

@webhdx

webhdx approved these changes Aug 7, 2018

@barbaragr barbaragr self-assigned this Aug 22, 2018

@barbaragr

Ready to merge @alongosz

@alongosz alongosz merged commit 22d9d75 into ezsystems:master Sep 11, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ezrobot/phpcsfixer Code review by ezrobot
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment