ftpignore #18 #57

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

peteruhnak commented Feb 8, 2012

Add option for excluding files from uploading as discussed in #18.

Owner

ezyang commented Feb 9, 2012

Can we have tests? It's a really big chunk of added code. It would be good if you could actually demonstrate this format is, in fact, equivalent to Git's.

Contributor

niklasf commented Feb 19, 2012

Sub.
(Side note: aff413e looks intresting regarding testing, but we might want to prefer unit testing, here.)

Contributor

peteruhnak commented Feb 19, 2012

Unfortunately i thrown away my tests when I was writing this separatly and then moved only the code…
However after reading glob manpage I realised I haven't solved matching slash within brackets, eg. [/], [!0], [.-0] and I don't see any way how to solve this in current implementation. I can push tests for the rest but there is probably no point without solving this first.

Contributor

peteruhnak commented Feb 20, 2012

Since I can't resolve that within this code I am closing this pull and will open another with fixed code.

@peteruhnak peteruhnak closed this Feb 20, 2012

@peteruhnak peteruhnak reopened this Feb 20, 2012

@peteruhnak peteruhnak closed this Feb 20, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment