Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 Deprecated funcs #311

Closed
xkpx64 opened this issue Jan 11, 2022 · 13 comments
Closed

PHP 8.1 Deprecated funcs #311

xkpx64 opened this issue Jan 11, 2022 · 13 comments

Comments

@xkpx64
Copy link

xkpx64 commented Jan 11, 2022

Deprecated: Return type of HTMLPurifier_PropertyListIterator::accept() should either be compatible with FilterIterator::accept(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in C:\Xampp\htdocs\libs\formr\HTMLPurifier.standalone.php on line 8340

Deprecated: Return type of HTMLPurifier_StringHash::offsetGet($index) should either be compatible with ArrayObject::offsetGet(mixed $key): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in C:\Xampp\htdocs\libs\formr\HTMLPurifier.standalone.php on line 8458

@davidrans
Copy link
Contributor

Is this fixed by #310?

What's the process for getting that change incorporated into a release?

@zerocrates
Copy link
Contributor

Yes, that PR included the attributes used to silence those two deprecation notices.

@marcovtwout
Copy link

@ezyang Since #310 was merged this issue can be closed. And could you please tag a new release so HTMLPurifier has PHP 8.1 support?

@ezyang ezyang closed this as completed May 3, 2022
@mashb1t
Copy link

mashb1t commented May 3, 2022

@ezyang which topics do still need to be finished until a new release can be created and can we support on that?

@ezyang
Copy link
Owner

ezyang commented May 4, 2022

just need me to find some time

@mashb1t
Copy link

mashb1t commented May 5, 2022

@ezyang what is your rough estimate when you'll find the time to do the release? Currently this blocks the Yii1 compatibility PR for PHP8.1 compatibility yiisoft/yii#4386 which would allow us as a business to add basically one more year of PHP support for our customers.
We as a business would highly appreciate to upgrade our Yii1 version at the start of next week including this fix.

@bytestream
Copy link
Contributor

@mashb1t there is nothing stopping you from forking the lib temporarily and coming back when a release is done. Open source doesn't have time requirements.

@mashb1t
Copy link

mashb1t commented May 5, 2022

@bytestream yes of course, thank you for mentioning this alternative. This is in fact another option but as far as i understood only a release/version tag is missing for this htmlpurifier to be officially PHP8.1 compatible to not break minimum stability requirements and having to fork both the yii1 framework repo and the htmlpurifier repo.

@mashb1t
Copy link

mashb1t commented May 17, 2022

@ezyang is there any chance you find the time to create a new release in the next 2 weeks?

@c-schmitz
Copy link

Yes, please release.

@ezyang
Copy link
Owner

ezyang commented Jun 25, 2022

it turns out baby life makes you very very lazy

@marcovtwout
Copy link

@ezyang Could you let me know if you plan to release it within the next 2-3 weeks? Otherwise I will use a development version for the next Yii 1 release. Thanks!

marcovtwout added a commit to yiisoft/yii that referenced this issue Jul 8, 2022
@pszalko
Copy link

pszalko commented Jul 11, 2022

@ezyang Will you be able to release a version with PHP 8.1 support anytime soon? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants