Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: using null instead of false. Fixed CPU is 100% on PHP 7.1.* #137

Merged
merged 3 commits into from Jun 3, 2017

Conversation

Projects
None yet
4 participants
@Xiphin
Copy link
Contributor

Xiphin commented Jun 2, 2017

No description provided.

@ezyang

This comment has been minimized.

Copy link
Owner

ezyang commented Jun 2, 2017

Thanks for the fix @Xiphin. Just to be clear, BOTH fixes are necessary to prevent the infinite loop? (I would have thought stdClass would be more risky than having current_li set to false: PHP looping on current_li sounds like a honking big bug in PHP!)

@Xiphin

This comment has been minimized.

Copy link
Contributor Author

Xiphin commented Jun 2, 2017

@ezyang using null instead of false is necessary to fix it. the bug is caused by forcing convert type.

@ezyang

This comment has been minimized.

Copy link
Owner

ezyang commented Jun 3, 2017

So, just to make sure, the renaming of stdClass is cosmetic?

In any case, thanks for submitting this fix. It would be a great service to PHP if you could boil this down to a minimal repro and post it to https://bugs.php.net/bug.php?id=74623; I am sure the PHP devs will fix this in PHP as well.

@ezyang ezyang merged commit ff16ed3 into ezyang:master Jun 3, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ezyang ezyang referenced this pull request Jun 3, 2017

Closed

use null instead of false #136

@trsteel88

This comment has been minimized.

Copy link

trsteel88 commented Jun 3, 2017

Can we get this tagged please @ezyang

@trsteel88

This comment has been minimized.

Copy link

trsteel88 commented Jun 4, 2017

@ezyang packagist hasn't indexed the latest tag. Are you able to execute a re-crawl?

https://packagist.org/packages/ezyang/htmlpurifier

@Xiphin

This comment has been minimized.

Copy link
Contributor Author

Xiphin commented Jun 5, 2017

@ezyang Suggestion: Enabling the Packagist service hook on your github "settings > Integrations & services >Services" ensures that your package will always be updated instantly when you push to GitHub.
https://packagist.org/about#how-to-update-packages

Xiphin added a commit to Xiphin/Purifier that referenced this pull request Jun 6, 2017

@Xiphin Xiphin referenced this pull request Jun 6, 2017

Merged

Update composer.json #60

Xiphin added a commit to xlstudio/purifier that referenced this pull request Jun 8, 2017

@0xPaul

This comment has been minimized.

Copy link

0xPaul commented Jun 15, 2017

This still appears to be untagged. Can we get a tag for this fix please?

@Xiphin

This comment has been minimized.

Copy link
Contributor Author

Xiphin commented Jun 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.