Goodbye lodash#100
Merged
Merged
Conversation
rokotyan
force-pushed
the
feature/goodbye-lodash
branch
from
28668b3 to
c7d1fb3
Compare
reb-dev
reviewed
Jan 19, 2023
| @@ -61,6 +61,7 @@ | |||
| "@types/lodash-es": "^4.17.6", | |||
Contributor
There was a problem hiding this comment.
Shouldn't we remove this too?
Contributor
|
We also need to remove the |
rokotyan
force-pushed
the
feature/goodbye-lodash
branch
from
3993b5f to
734787a
Compare
Contributor
Author
|
@reb-dev Thanks for pointing our the issues! I've just fixed along with a few other thing. |
rokotyan
force-pushed
the
feature/goodbye-lodash
branch
from
734787a to
eb21b20
Compare
reb-dev
previously approved these changes
Feb 2, 2023
rokotyan
force-pushed
the
feature/goodbye-lodash
branch
from
eb21b20 to
ccc583d
Compare
reb-dev
approved these changes
Feb 22, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces lodash with our own functions and uses throttle from the
throttle-debouncepackage, saving the users about 90KB in the final app bundle.Before
After