-
Notifications
You must be signed in to change notification settings - Fork 59
Chord Diagram: Refactoring, Docs, Examples #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
76568c3 to
5d3c194
Compare
8db6604 to
14e0056
Compare
0e131ec to
c061853
Compare
rokotyan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reb-dev Overall looks great! I've only left a few comments to the code.
2d823c1 to
81e07af
Compare
81e07af to
e8ac99d
Compare
|
@reb-dev Looks like we need to add an image to the Gallery example |
|
@reb-dev Also there's a problem with labels alignment when Screen.Recording.2023-02-14.at.2.33.54.PM.web.mp4 |
|
@reb-dev One more thing, the fact that the links are being re-drawn every time the graph updates means that our component doesn't implement the enter-update-exit logic properly. We can fix that fairly easily by providing the second argument to the You can check how it's done for the |
854e7bf to
ae98d9e
Compare
ae98d9e to
578902e
Compare
a3e2f7c to
52f073d
Compare
35a9374 to
bd45c3e
Compare


#97