Skip to content

Conversation

@reb-dev
Copy link
Contributor

@reb-dev reb-dev commented Jan 19, 2023

image

#97

@reb-dev reb-dev marked this pull request as draft January 19, 2023 00:20
@reb-dev reb-dev linked an issue Jan 20, 2023 that may be closed by this pull request
5 tasks
reb-dev added a commit that referenced this pull request Jan 20, 2023
@reb-dev reb-dev force-pushed the feat/chord-diagram branch from 76568c3 to 5d3c194 Compare January 20, 2023 01:43
reb-dev added a commit that referenced this pull request Jan 30, 2023
@reb-dev reb-dev force-pushed the feat/chord-diagram branch 4 times, most recently from 8db6604 to 14e0056 Compare February 2, 2023 14:47
@reb-dev reb-dev force-pushed the feat/chord-diagram branch 3 times, most recently from 0e131ec to c061853 Compare February 7, 2023 01:09
Copy link
Contributor

@rokotyan rokotyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reb-dev Overall looks great! I've only left a few comments to the code.

@reb-dev reb-dev force-pushed the feat/chord-diagram branch 3 times, most recently from 2d823c1 to 81e07af Compare February 10, 2023 23:22
@reb-dev reb-dev marked this pull request as ready for review February 14, 2023 16:31
@rokotyan
Copy link
Contributor

@reb-dev Looks like we need to add an image to the Gallery example
image

@rokotyan
Copy link
Contributor

@reb-dev Also there's a problem with labels alignment when radiusScaleExponent is not default:

Screen.Recording.2023-02-14.at.2.33.54.PM.web.mp4

@rokotyan
Copy link
Contributor

@reb-dev One more thing, the fact that the links are being re-drawn every time the graph updates means that our component doesn't implement the enter-update-exit logic properly. We can fix that fairly easily by providing the second argument to the .data calls:
image

You can check how it's done for the Graph component and copy the code from there.

@reb-dev reb-dev force-pushed the feat/chord-diagram branch 3 times, most recently from 854e7bf to ae98d9e Compare February 17, 2023 21:01
@reb-dev reb-dev force-pushed the feat/chord-diagram branch from ae98d9e to 578902e Compare March 2, 2023 00:17
@reb-dev reb-dev requested a review from rokotyan March 2, 2023 00:49
@reb-dev reb-dev force-pushed the feat/chord-diagram branch 2 times, most recently from a3e2f7c to 52f073d Compare March 3, 2023 00:40
@reb-dev reb-dev force-pushed the feat/chord-diagram branch from 35a9374 to bd45c3e Compare March 8, 2023 21:28
@rokotyan rokotyan changed the title Chord Diagram: Fix link logic Chord Diagram: Refactoring, Docs, Examples Mar 9, 2023
@rokotyan rokotyan merged commit b030f73 into main Mar 9, 2023
@rokotyan rokotyan mentioned this pull request Apr 19, 2023
@rokotyan rokotyan deleted the feat/chord-diagram branch May 22, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multi-level Chord Diagram

3 participants