-
Notifications
You must be signed in to change notification settings - Fork 52
Component | Graph: ELK Support #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
13d8c66
to
824afd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really cool! Nice work.
One thing I'm not sure about: is there a straight forward way to change the layout algorithm? Because when I change the dev example's props to layoutElkSettings={{ 'elk.algorithm': 'radial' }}
I get an error, but inside the component itself I can just add that to the layout options and it works:
…AULT_ELK_SETTINGS #141
…rties in quotes #0
6f25389
to
40351d7
Compare
@reb-dev Thanks! ELK has a quite sophisticated layout configuration logic that I've tried to wrap it a little to suit our primary use case out of the box. But it looks like it broke some other things, so I've simplified my logic to avoid issues like the one you've found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This PR implements initial ELK support, which is the best layout engine for diagrams as of today. ELK Layered Layout can be a good alternative for our Parallel Layout when you need more nesting (panels within panels ...). Besides that ELK has other layouts available. #141