Repository navigation
Theme | New theme: Patterns - #275
Merged
Merged
Conversation
reb-dev
force-pushed
the
feature/accessibility-theme
branch
from
September 13, 2023 22:24
553f7d1 to
48662c5
Compare
rokotyan
reviewed
Sep 14, 2023
rokotyan
left a comment
Contributor
There was a problem hiding this comment.
Overall looks great, the implementation is clean and clear. I've only left a few comments.
reb-dev
force-pushed
the
feature/accessibility-theme
branch
from
October 3, 2023 21:57
48662c5 to
617352a
Compare
reb-dev
force-pushed
the
feature/accessibility-theme
branch
from
October 10, 2023 23:54
617352a to
592f7f9
Compare
rokotyan
approved these changes
Oct 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR adds a new theme to the library.
Pattern Theme
When
document.bodyhas the classtheme-patternswe automatically apply patterns of two types:--vis-pattern${i}to a valid SVG def of amaskelement. The default palette looks like:with the corresponding css variables:
bulletShapeproperty is set to"line". Users can customize these patterns by assigning--vis-pattern-marker${i}to a valid SVG def of amarkerelement or--vis-pattern-dasharray${i}to a valid value for the stroke-dasharray property. The default palette looks like:with the corresponding css variables:
Other changes: