Skip to content

Graph: New Features - #322

Merged
reb-dev merged 20 commits into
f5:mainfrom
rokotyan:feature/graph-new-features
Mar 7, 2024
Merged

reb-dev merged 20 commits into
f5:mainfrom
rokotyan:feature/graph-new-features

Conversation

@rokotyan

@rokotyan rokotyan commented Jan 5, 2024

Copy link
Copy Markdown
Contributor

This PR adds a number of new features to the Graph component:

  • Curved Links
  • Using SVG for node icons (set as custom defs)
  • Supporting longer link labels
  • Better typings for Dagre graph layout settings
  • Some refactoring and clean up

There're still a few things to do but overall the PR can be considered as ready for review.

SCR-20240105-motu SCR-20240105-lsdt

@rokotyan
rokotyan force-pushed the feature/graph-new-features branch from 0e8a58d to eeafa3a Compare January 5, 2024 22:12
Comment thread packages/ts/src/components/graph/modules/shape.ts Fixed
@rokotyan
rokotyan force-pushed the feature/graph-new-features branch from eeafa3a to 0dc8f5c Compare January 8, 2024 21:20
Comment thread packages/ts/src/components/graph/modules/shape.ts Fixed
@rokotyan
rokotyan force-pushed the feature/graph-new-features branch from 0dc8f5c to 8235b10 Compare January 9, 2024 18:26
- Provide accessor functions to `linkDistance`, `linkStrength`, and `charge`.
- Set the number of iterations with the `numIterations` property.
- Fix node positions after the simulation to avoid layout shuffling.

#0
- Additional dimmed node styles
- Exporting selectors for dimmed nodes
- Updating the class names

#0
Removing force layout translate because it causes issues when adding new nodes to the graph iteratively

#0
@rokotyan
rokotyan force-pushed the feature/graph-new-features branch from e38557d to 1afbb3e Compare January 18, 2024 22:14
@rokotyan
rokotyan force-pushed the feature/graph-new-features branch from 828bb92 to 71ad692 Compare January 25, 2024 21:39
@TasoOneAsia TasoOneAsia added the cla-signed Authors have signed the F5 contributor license agreement label Feb 5, 2024
@reb-dev
reb-dev self-requested a review February 27, 2024 20:50

@reb-dev reb-dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. If there is nothing more to add, would you like to remove the draft status from this PR? Then I will merge.

@rokotyan
rokotyan marked this pull request as ready for review February 29, 2024 03:03
@rokotyan

Copy link
Copy Markdown
Contributor Author

Thanks @reb-dev! I've marked the PR as ready for review.

I may have some additional tweaks to the graph component in the future, but certainly not within the next few weeks. So I think it makes sense to merge this one.

@reb-dev
reb-dev merged commit 3265620 into f5:main Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Authors have signed the F5 contributor license agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants