TopoJSON Map Fixes#425
Merged
Merged
Conversation
…dding topojson layer fixes: #400
lee00678
requested changes
Aug 7, 2024
lee00678
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fixes! This is great.
I just have one issue I've noticed. (pan or zoom on this map, the map disappears)
Screen.Recording.2024-08-07.at.11.30.08.AM.mov
Comment on lines
+26
to
+30
| events={{ | ||
| [TopoJSONMap.selectors.feature]: { | ||
| // click: c => console.log(c), | ||
| }, | ||
| }} |
Contributor
|
Thanks for the fixes @reb-dev! |
Contributor
Author
Can you try |
Collaborator
My bad, it's working after the clean install. |
lee00678
approved these changes
Aug 12, 2024
This was
linked to
issues
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses multiple issues with TopoJSON maps, makes some revisions to the TopoJSONMap component doc page, and adds a few new examples to the demo app.
Changes:
mapFitToPointsis enabled will reset the view entirelymapFitToPointsis enabled, the map will now refit to the new points (previously did nothing)