Solid Integration

[rokotyan]

A clone of #422, but rebased from main instead of merging. Let's see if the build passes.

[rokotyan]

@hngngn @lee00678

I was able to make the solid build work, but the website build is failing because it can't find the examples for some reason. If you can take a look into this, it would be great.

[rokotyan]

There is one more problem with the build I've found. All Unovis libraries preserve the source directory structure in the dist, making it possible to import components individually, like import { VisAnnotations } from '@unovis/react/components/area':

The Solid build doesn't have that, and it seems to be bundling all of @unovis/ts plus its dependencies. This will have a negative effect on the final bundle size of the apps that use @unovis/solid.

I think you can take a look at the vite.config.ts from packages/vue and use it as an example of the build configuration.

[lee00678]

@hngngn @lee00678

I was able to make the solid build work, but the website build is failing because it can't find the examples for some reason. If you can take a look into this, it would be great.

Yea, this happened to me during my test a couple of days ago as well. (#475 (comment)) Seems to be this is caused by solid, so we may need some insights from @hngngn

[hngngn]

Sorry for the late reply—I've been pretty busy lately. I'll look into the issue and report back ASAP.

[hngngn]

I've already pushed a fix for both problems you're facing. Can you test it? @rokotyan @lee00678

[lee00678]

Thanks for the fix @hngngn. Looks like all checks passed. @rokotyan, should I go ahead and merge this PR, then close #422?

[rokotyan]

@lee00678 Looks good, I think we can merge it

Thanks @hngngn!

[hngngn]

@rokotyan I'm having trouble with the gallery right now, and the last time I checked, the example of Grouped Bar with Brush and Interactive Legend was broken. I'll report back if everything is working properly

[hngngn]

I've pushed a fix. Could you test it?

[lee00678]

@rokotyan do you mind pushing the latest fix so I can do a last round of testing before merging?

[rokotyan]

@lee00678 Done. Amended the main commit and did a force push.

[lee00678]

I think you can take a look at the vite.config.ts from packages/vue and use it as an example of the build configuration.

This looks good!

[lee00678]

@hngngn Thanks for this contribution! This will be released in 1.5.0.