Conversation
| @zerollup/ts-transform-paths perpetual MIT 1.7.18 Stefan Zerkalica zerkalica@gmail.com | ||
| react perpetual MIT 16.14.0 n/a | ||
| react-dom perpetual MIT 16.14.0 n/a | ||
| react perpetual MIT 18.3.1 n/a |
There was a problem hiding this comment.
Surprised to see the React version change without any package.json updates
There was a problem hiding this comment.
Yea, good question. I think, based on my understanding, the react version gets hoisted to the parent level, so because of the later version in packages/website/package-lock.json, this become a later version.
| x: d=>d.x, | ||
| y: d=>d.y, | ||
| }); | ||
| export const MyComponent = ({ type = "XYWrapper", n = 10, name = "StackedBar", x = (d) => d.x, y = (d) => d.y, data=generateDataRecords(n), ...customProps }) => { |
There was a problem hiding this comment.
I like this idea, but I find the name MyComponent sound a little bit too generic. Maybe DocsStackedBar instead?
@lee00678 Can you tell more about the |
81eb7d3 to
741ccf7
Compare
@rokotyan This is warning we are getting caused by |
|
@lee00678 I believe this error comes from React and is related to React's The only place where Unovis uses it is here: unovis/packages/react/src/composites/time-series/index.tsx Lines 107 to 112 in 793277d But this component part is not being used anywhere. I thought of releasing something like this to give our users slightly more complex components, but now I don't think it's a good idea (I would rather share it as an example). I've tried commenting it out but still seeing the warning, so maybe some our our or Docusaurus dependencies uses |
Resolved in a separate PR: #491 |
I actually think this issue maybe simply caused by the fact we are calling them |
|
@lee00678 Maybe, let's try it |
That seems to fix all the |
|
@lee00678 Great! I didn't have any other comments so I think we can go ahead and merge this |
237bc7b to
7be54cd
Compare
…m install:clean Website | Upgrade: Latest docusaurus V3 Svelte | Update: Name fix for docusaurus.config.js
…ow; Remove overrides in package.json
41fe402 to
c810d44
Compare





This PR addresses the dependency vulnerabilities by upgrading to docusaurus v3.
It's a pretty big change, it includes some root folder
package.jsonupdate as well. In order to use react and reactdom@18 (required for v3), we need to removepackages/website/package-loc.jsonfrominstall:cleanscript. This way we can ensure the build uses react@18.defaultPropsin ourmdxfile will cause an error/warning message. This is caused by MDX scanning the docs and look for words likedefaultProps, we don't actually use them in our doc, they are just javascript objects. So renamed the example props.Added a new
authors.ymlfile underreleases, this way we no longer to copy over all the author information for each release article.To test: In the root folder do a
npm run install:clean,npm run build, then runnpm run website.