Skip to content

Website | Gallery: Adding a new patchy line chart example - #558

Merged
lee00678 merged 1 commit into
mainfrom
hanumandla/intro-patchy-line-gallery-example
Jul 18, 2025
Merged

Website | Gallery: Adding a new patchy line chart example#558
lee00678 merged 1 commit into
mainfrom
hanumandla/intro-patchy-line-gallery-example

Conversation

@suryahanumandla

@suryahanumandla suryahanumandla commented May 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Introduced patchy line chart gallery example

screenshot

Screenshot 2025-07-11 at 10 14 55 AM
Screen.Recording.2025-07-11.at.10.54.18.AM.mov

@suryahanumandla suryahanumandla changed the title Website | Gallery: Adding a new patchy line chart example Draft: Website | Gallery: Adding a new patchy line chart example May 2, 2025
@github-actions

github-actions Bot commented May 2, 2025 •
edited
Loading

Copy link
Copy Markdown

CLA Assistant Lite bot ✅ All required contributors have signed the F5 CLA for this PR. Thank you!

@lee00678
lee00678 force-pushed the hanumandla/intro-patchy-line-gallery-example branch from 3709c25 to 87555f2 Compare May 6, 2025 19:12
@suryahanumandla
suryahanumandla force-pushed the hanumandla/intro-patchy-line-gallery-example branch 2 times, most recently from 793f35e to 430528f Compare May 7, 2025 07:46
lee00678
lee00678 reviewed May 7, 2025
View reviewed changes

@lee00678 lee00678 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Just have a couple small things.

Comment thread packages/shared/examples/_previews/patchy-line-chart-dark.png
Comment thread packages/shared/examples/patchy-line-chart/patchy-line-chart.tsx Outdated
@lee00678

lee00678 commented May 7, 2025

Copy link
Copy Markdown
Collaborator

@hngngn, there's some solid error in this example when running the gallery in solid folder. Specifically when show scatter is disabled then enabled. It seems we don't actually have any example using <Show when...> in our gallery.
image (1)

This solid example does work in Stackblitz with 1.5.1. Just wondering if you have any input on this. Thanks!

@suryahanumandla
suryahanumandla force-pushed the hanumandla/intro-patchy-line-gallery-example branch from 430528f to 4e35ef8 Compare July 2, 2025 06:51
@lee00678 lee00678 mentioned this pull request Jul 10, 2025
Merged
@suryahanumandla
suryahanumandla force-pushed the hanumandla/intro-patchy-line-gallery-example branch from 4e35ef8 to 9e935ce Compare July 11, 2025 05:14
@suryahanumandla

suryahanumandla commented Jul 11, 2025

Copy link
Copy Markdown
Collaborator Author

@hngngn, there's some solid error in this example when running the gallery in solid folder. Specifically when show scatter is disabled then enabled. It seems we don't actually have any example using <Show when...> in our gallery. image (1)

This solid example does work in Stackblitz with 1.5.1. Just wondering if you have any input on this. Thanks!

Issue has been resolved with #602

@suryahanumandla suryahanumandla changed the title Draft: Website | Gallery: Adding a new patchy line chart example Website | Gallery: Adding a new patchy line chart example Jul 11, 2025
@suryahanumandla
suryahanumandla requested a review from lee00678 July 11, 2025 05:26
lee00678
lee00678 approved these changes Jul 18, 2025
View reviewed changes

@lee00678 lee00678 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lee00678
lee00678 merged commit 89f7154 into main Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lee00678 lee00678 lee00678 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@suryahanumandla @lee00678