Container | XY: Handle edge cases when scaleByDomain is true#588
Merged
Conversation
There could be situations when there are no data points, or only a single data point remains after `filterDataByRange` when calculating the domain. This was causing XY charts to go off-screen because the domain was calculated improperly. This change addresses the issue by including neighboring data points in the filtered results.
rokotyan
force-pushed
the
fix/scale-by-domain-edge-cases
branch
from
659343c to
ab6208d
Compare
lee00678
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There could be situations when there are no data points, or only a single data point remains after
filterDataByRangewhen calculating the domain. This was causing XY charts to go off-screen because the domain was calculated improperly.This change addresses the issue by including neighboring data points in the filtered results.
Before
After