This repository was archived by the owner on Feb 11, 2022. It is now read-only.
Multiple public ips closes #46 #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
would this assume each application would have it's own EIP? |
Contributor
Author
if you choose to use it that way. the only thing that this does is preallocate n ips to the public nic. You could then use one of those ip addresses for one application and another to serve multiple applications based upon url. |
mjmenger
changed the title
codygreen
approved these changes
Dec 19, 2019
Contributor
codygreen
left a comment
codygreen
left a comment
There was a problem hiding this comment.
Looks good. For the failover extension, we'll need the ability to statically set the private IPs but that can be added in a subsequent PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the intent of this is to provide a mechanism for allocating public ips that would be assigned as application destinations. And, also to output the ip addresses in an easy to consume fashion.