Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add widescreen rendering #413

Open
fabiangreffrath opened this issue May 2, 2019 · 10 comments

Comments

@fabiangreffrath
Copy link
Owner

commented May 2, 2019

The idea is to probe the screen's dimensions (e.g. 1280x768), scale them down to WIDTHx200 and adjust field-of-view and centered patch drawing to the difference between WIDTH and 320.

@Zodomaniac

This comment has been minimized.

Copy link
Collaborator

commented Jun 5, 2019

Will this result in preserving the pixel aspect ratio but using the full monitor field of view?

@fabiangreffrath

This comment has been minimized.

Copy link
Owner Author

commented Jun 5, 2019

Yep, that's the plan.

@Zodomaniac

This comment has been minimized.

Copy link
Collaborator

commented Jun 5, 2019

I'd like to keep the option to adjust the pixel aspect ratio still.
P.S. I'd suggest to name the new option 'No Letterboxing' as Full screen is another option from the Setup tool.

@fabiangreffrath

This comment has been minimized.

Copy link
Owner Author

commented Jun 5, 2019

Yes, aspect ratio correction will still be there.
I'd like to call it "widescreen rendering", btw, because this is what it actually is about.

@Zodomaniac

This comment has been minimized.

Copy link
Collaborator

commented Jun 7, 2019

How will the title screens and menu be rendered? Will they be stretched the same way as for unconstrained aspect ratio now?
Will the renderer be still 16:10 (640x400, 320x200)?

@fabiangreffrath

This comment has been minimized.

Copy link
Owner Author

commented Jun 8, 2019

How will the title screens and menu be rendered? Will they be stretched the same way as for unconstrained aspect ratio now?

I think they will be rendered with the correct aspect ratio and with black vertical bars left and right.

Will the renderer be still 16:10 (640x400, 320x200)?

No, the horizontal resolution (and thus field-of-view) will have to get increased.

@Zodomaniac

This comment has been minimized.

Copy link
Collaborator

commented Jun 8, 2019

Yes, I like it this way :)

@Zodomaniac

This comment has been minimized.

Copy link
Collaborator

commented Jun 18, 2019

Actually the 16:10 widescreen option in Doom Retro was done this way, changing the FOV and not the pixel aspect ratio. But on 16:9 monitors it's still letterboxed.

@fabiangreffrath

This comment has been minimized.

Copy link
Owner Author

commented Jun 18, 2019

Actually the 16:10 widescreen option in Doom Retro was done this way, changing the FOV and not the pixel aspect ratio. But on 16:9 monitors it's still letterboxed.

Erm... last time I checked this was merely the view with the status bar, but with the status bar cut off.

@Zodomaniac

This comment has been minimized.

Copy link
Collaborator

commented Jun 18, 2019

Here's what the widescreen in Doom Retro looks like: 1728x1080 (16:10) preserving the 1.2 pixel aspect ratio and letterboxed on 1920x1080 (16:9) monitor.
Entryway

@Zodomaniac Zodomaniac added this to the Crispy Doom 5.6 milestone Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.