Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[K4] 4.0 Compatibility #174

Open
afbora opened this issue Sep 20, 2023 · 10 comments
Open

[K4] 4.0 Compatibility #174

afbora opened this issue Sep 20, 2023 · 10 comments

Comments

@afbora
Copy link

afbora commented Sep 20, 2023

Cannot read properties of undefined (reading 'map')
Cannot read properties of undefined (reading 'page')

fields:
  text:
    type: markdown

Also you'll see some icons deprecated when you check browser console:

Deprecated: Custom icon "horizontal-rule" seems to use a 16x16 viewbox which has been deprecated. In an upcoming version, Kirby will only support custom icons with a 24x24 viewbox by default. If you want to continue using icons with a different viewport, please wrap them in an element with the corresponding viewBox attribute.

Deprecated: Custom icon "special-chars" seems to use a 16x16 viewbox which has been deprecated. In an upcoming version, Kirby will only support custom icons with a 24x24 viewbox by default. If you want to continue using icons with a different viewport, please wrap them in an element with the corresponding viewBox attribute.

Kirby 4.0.0-beta.1 (v4/develop branch)

@animaux
Copy link

animaux commented Oct 23, 2023

Is there a v4-compatible version on the horizon? This is one of my most precious plugins :)

@fabianmichael
Copy link
Owner

@animaux That currently depends on my availability. Still drowning in client work, but should be possible to wokr on that soon.

@animaux
Copy link

animaux commented Oct 26, 2023

Thanks for your heads-up! I can totally relate :).

@animaux
Copy link

animaux commented Nov 30, 2023

@fabianmichael 3.0.0 Alpha looks great so far, many thanks!

Only minor cosmetic things:

  • Text size is bigger compared with a textarea field (maybe on purpose?)
  • Icon for hr looks more like »space between paragraphs«

markdown field followed by a textarea field:

Bildschirmfoto 2023-11-30 um 08 22 18

hr icon:

Bildschirmfoto 2023-11-30 um 08 22 44

@fabianmichael
Copy link
Owner

@animaux Thanks for your feedback, I hope Alpha 2 fixes these issues: https://github.com/fabianmichael/kirby-markdown-field/releases/tag/3.0.0-alpha.2

@animaux
Copy link

animaux commented Nov 30, 2023

That was quick! Looks perfect now, many thanks!

@srijan
Copy link

srijan commented Nov 30, 2023

Just updated to 3.0.0-alpha.2 - it works for me as well without issues. Thanks 👍.

(Originally published at: https://srijan.ch/notes/2023-11-30-002)

@tobimori
Copy link
Contributor

tobimori commented Feb 5, 2024

hey, any updates?

@fabianmichael
Copy link
Owner

not yet, things are still a bit messy around here … but nothing to worry about, this is still on my to do list.

@tobimori
Copy link
Contributor

tobimori commented Feb 9, 2024

Edit: This is fixed when installing dev-main and not 3.0-alpha.2.


Weird bug I noticed, as soon as I have a blockquote inside my Markdown field, hrs aren't rendering correctly.
With blockquote:

CleanShot 2024-02-09 at 17 19 00@2x

Without:

CleanShot 2024-02-09 at 17 19 19@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants