Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#374: Date hierarchy params fix #375

Merged

Conversation

jeroenpeters1986
Copy link
Contributor

@jeroenpeters1986 jeroenpeters1986 commented Mar 6, 2024


name: Pull request
about: Submit a pull request for this project
assignees: fabiocaccamo


Describe your changes
It seems that the params are now a list instead of the direct value

Related issue
Issue #374

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added tests for the proposed changes.
  • I have run the tests and there are not errors.

@fabiocaccamo fabiocaccamo added the bug Something isn't working label Mar 6, 2024
@fabiocaccamo fabiocaccamo self-requested a review March 6, 2024 23:24
@jeroenpeters1986
Copy link
Contributor Author

Hey @fabiocaccamo , the tests are now running fine, but the code has been "awarded" a 9 for complexity. What would you like to do with this? I could add some comments but that would not make it less complex I think. I can also make the if statements span multiple lines, but the syntax is pretty "pythonic" like this. What is your opinion about this?

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.38%. Comparing base (3293bea) to head (357f938).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
+ Coverage   97.35%   97.38%   +0.03%     
==========================================
  Files          38       38              
  Lines         416      421       +5     
==========================================
+ Hits          405      410       +5     
  Misses         11       11              
Flag Coverage Δ
unittests 97.38% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabiocaccamo
Copy link
Owner

@jeroenpeters1986 I will improve code quality myself, don't worry. Thank you for the PR!

@fabiocaccamo fabiocaccamo merged commit b1bb5d0 into fabiocaccamo:main Mar 7, 2024
53 of 54 checks passed
@jeroenpeters1986
Copy link
Contributor Author

No problem! Thanks for merging it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants