From 3d02439b9a85a7f539861318514e6c3a6afddd34 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Igor=20Ani=C4=87?= Date: Fri, 12 Apr 2019 17:51:53 +0200 Subject: [PATCH] fix exit status code (#637) Fabio always returned status code 1. Event on clean exit. Shutdown of http server is treated as fatal: [FATAL] http: Server closed [FATAL] ui: http: Server closed Http server Serve method always returns non nil error: https://golang.org/pkg/net/http/#Server.Serve ErrServerClosed should be treated as clean exit. "After Shutdown or Close, the returned error is ErrServerClosed." --- proxy/serve.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/proxy/serve.go b/proxy/serve.go index cbe179615..cdb90cbe4 100644 --- a/proxy/serve.go +++ b/proxy/serve.go @@ -103,5 +103,8 @@ func serve(ln net.Listener, srv Server) error { mu.Lock() servers = append(servers, srv) mu.Unlock() - return srv.Serve(ln) + if err := srv.Serve(ln); err != http.ErrServerClosed { + return err + } + return nil }