Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsondoc offline placeholder verification #136

Closed
yenn opened this issue Aug 18, 2015 · 1 comment
Closed

Jsondoc offline placeholder verification #136

yenn opened this issue Aug 18, 2015 · 1 comment
Assignees
Labels
Milestone

Comments

@yenn
Copy link

yenn commented Aug 18, 2015

GIVEN

  • Using replacement of the JSONDOC_OFFLINE_PLACEHOLDER by maven replacer plugin.

WHEN

  • jsondoc content contains exactly 4 underscore characters

THEN

  • condition if(jsondoc.split('_').length != 5) will fail and the content will not be loaded despite the fact that the placeholder has been replaced

Replacement verification condition is wrong.

@fabiomaffioletti
Copy link
Owner

Good catch, thank you!

@fabiomaffioletti fabiomaffioletti self-assigned this Aug 19, 2015
@fabiomaffioletti fabiomaffioletti added this to the 1.2.1 milestone Aug 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants