Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would you accept a pull request to remove the servlet-api dependency? #46

Closed
toranb opened this issue Dec 31, 2014 · 2 comments
Closed

Would you accept a pull request to remove the servlet-api dependency? #46

toranb opened this issue Dec 31, 2014 · 2 comments
Assignees
Labels
bug
Milestone

Comments

@toranb
Copy link

@toranb toranb commented Dec 31, 2014

Today I tried to use this w/ a springboot app and ran into a ton of pain. I finally realized it wouldn't boot because of a conflict between servlet-api versions. I was using 3.1 but this app today uses 2.4

Would you accept a PR to remove this hard coded dependency so others using springboot won't feel this pain?

https://github.com/fabiomaffioletti/jsondoc/blob/master/pom.xml#L123

Thank you for maintaining such a great OSS project !

@toranb toranb changed the title Would you accept a pull request to remove the Would you accept a pull request to remove the servlet-api dependency? Dec 31, 2014
@benkiefer
Copy link
Contributor

@benkiefer benkiefer commented Dec 31, 2014

See #47 which also includes support for patch requests. Thanks!

@fabiomaffioletti
Copy link
Owner

@fabiomaffioletti fabiomaffioletti commented Jan 1, 2015

Hello, I am on it. I am also writing a jsondoc starter for spring boot which I'll push shortly. I'll release it and document how to use it soon. Anyway, glad to see that, apart from the servlet version, it's working with spring boot.

@fabiomaffioletti fabiomaffioletti added this to the 1.0.7 milestone Jan 1, 2015
@fabiomaffioletti fabiomaffioletti added the bug label Jan 1, 2015
@fabiomaffioletti fabiomaffioletti self-assigned this Jan 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.