Force SSL + Forward SSL from Nginx to the container #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was causing http urls instead of https. see: #166 Solution is to force use SSL, and forward it from Nginx to the container See more: rails/rails#22965
Closed
pral2a
reviewed
May 4, 2020
|
@viktorsmari one thing to check here I'm not entirely sure. You usually do SSL on NGINX to reduce the impact on your app layer (rails). Shouldn't we avoid enabling SSL on rails? |
|
I read about it here and it looks like is not actually adding the SSL layer, it just looks like it tells the app it will be served over SSL and sets the correct headers, protocols, etc... isn't, it? https://stackoverflow.com/questions/15676596/what-does-force-ssl-do-in-rails |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was causing http urls instead of https. see:
#166
Solution is to force use SSL, and forward it from Nginx to the container
See more: rails/rails#22965
If this works without problems, we can also update the auth container to use
force_ssl = true