[JS/TS] Replace Error with Exception#4197
Merged
Merged
Conversation
ncave
force-pushed
the
error
branch
2 times, most recently
from
445f482 to
e06954c
Compare
Collaborator
Author
|
@MangelMaxime This is ready for merging, I tagged you in case you want to review and chime in, but do let me know if you don't have time at the moment, and I can merge it. |
Member
|
@ncave This looks fine to me. I was not active the last 2 weeks because I was on vacation :) 2 weeks with no computer feels good sometimes 😇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errortype usage withExceptionclass for consistency.This fixes some TS exception type mismatch issues, since most exceptions were already derived from
Exception.