Permalink
Commits on Sep 22, 2012
Commits on Aug 4, 2012
  1. Merge pull request #107 from maletor/patch-1

    sobrinho committed Aug 4, 2012
    Update readme with lib
Commits on Jul 13, 2012
  1. Update master

    maletor committed Jul 13, 2012
Commits on Jun 1, 2012
  1. Merge pull request #97 from moonmaster9000/patch-1

    thiagopradi committed Jun 1, 2012
    fix/clarify english grammer in README
Commits on Mar 9, 2012
  1. Merge pull request #83 from akicho8/bugfix

    gaffneyc committed Mar 9, 2012
    Association building with a block was not calling the block.
  2. Block does not receive bugfix

    akicho8 committed Mar 9, 2012
Commits on Mar 8, 2012
  1. Refactoring how groups are accessed to remove enapsulation breaking.

    gaffneyc committed Mar 8, 2012
    Groups were stored in a variable inside Octopus::Proxy and to use them a
    few places were breaking incapsulation by using instance_variable_get.
    This defines a small API for accessing the group information so we can
    use the interface instead of needing to know the implementation details.
Commits on Mar 7, 2012
  1. Fixed a couple missed table renamings

    gaffneyc committed Mar 7, 2012
    octopus_shard2 => octopus_shard_2
  2. Remove ActionPack as a dependency.

    gaffneyc committed Mar 7, 2012
    The one test that was using it has been nuked.
Commits on Mar 1, 2012
  1. Refactoring to Octopus.enabled? for checking if we should hook into

    gaffneyc committed Mar 1, 2012
    ActiveRecord or not.
    
    Seems that Octopus shouldn't hook in if the configuration is empty but
    there is an outstanding broken test. Will have to revisit later.
  2. Refactoring to make the switch a little more obvious.

    gaffneyc committed Mar 1, 2012
    Start of the process of getting familiar with the codebase.
Commits on Feb 29, 2012
  1. Require just "spec_helper" instead of the expanded path.

    gaffneyc committed Feb 29, 2012
    Unnecessary but brings it up to more recent Rails conventions.
  2. Removing controller spec as it's pending and doesn't make sense.

    gaffneyc committed Feb 29, 2012
    Octopus doesn't hook into ActionController at all so it doesn't make
    sense to test on this level.
  3. Add ar-octopus that auto-requires octopus.

    gaffneyc committed Feb 29, 2012
    Makes bundler gem specifications a little nicer. Didn't update the
    rails 2 documenation as I can't remember if remove :lib would be valid.
  4. Shameless renaming of tables to include an underscore before the number.

    gaffneyc committed Feb 29, 2012
    Also includes a refactoring of creating and dumping tables and using the
    environment variable for mysql user in testing shards config.
  5. Rails 3.2.x compatability.

    gaffneyc committed Feb 29, 2012
    Replaced write_inheritable_attribute and read_inheritable_attribute with
    class_attribute. This required renaming establish_connection and
    set_table_name since they attempted to overload existing class methods.
    
    Changed from #set_table_name to #table_name= since set_table_name is
    deprecated.
    
    proxy_spec.rb:50 is currently broken inside of ActiveRecord's connection
    pool's #checkout method.
  6. Add rails32 appraisal and remove generated gemfiles.

    gaffneyc committed Feb 29, 2012
    Part of the getting started process is to run rake appraisal:install so
    these files will be regenerated again anyways. Plus they are
    auto-generated which seems odd to keep in source control.
  7. Removing MetricFu due to it not working on 1.9.3.

    gaffneyc committed Feb 29, 2012
    MetricFu depends on Rcov which is not compiling on 1.9.3 (which is
    arguably the Future(tm)).
  8. Generalize the require to ActiveSupport class extensions.

    gaffneyc committed Feb 29, 2012
    Rails 3.2 changes inheritable_attributes to just attribute and this will
    work across both versions. This adds a few extensions that Octopus isn't
    using but nothing that ActiveRecord probably doesn't bring in on it's
    own.
  9. Ignore vim swap files.

    gaffneyc committed Feb 29, 2012
  10. Fixing update_attributes on rails 3.0.x

    gaffneyc committed Feb 29, 2012
    The persistence hooks don't use the arguments so they can be ignored for
    the most part.
Commits on Jan 27, 2012
  1. Merge pull request #76 from kanevski/master

    sobrinho committed Jan 27, 2012
    Fix to Rails 2 compatibility
Commits on Jan 26, 2012
Commits on Jan 22, 2012
  1. Merge pull request #73 from john/master

    sobrinho committed Jan 22, 2012
    Switched to ActiveSupport::VERSION::MINOR for version detection
Commits on Jan 21, 2012
  1. Merge pull request #71 from kanevski/master

    thiagopradi committed Jan 21, 2012
    Improved logging integration for Rails 3+
  2. Merge pull request #66 from matsadler/master

    thiagopradi committed Jan 21, 2012
    Fix for proxy when adapter modifies the passed config
  3. Update lib/octopus.rb

    john committed Jan 21, 2012
  4. Spec name tweak

    kanevski committed Jan 21, 2012
  5. Added integration with ActiveRecord instrumentation for better loggin…

    kanevski committed Jan 21, 2012
    …g support for Rails 3+
Commits on Jan 20, 2012
  1. Merge pull request #70 from peer2/master

    sobrinho committed Jan 20, 2012
    The syntax for this has changed with rails 3.1 (optional parameter)
Commits on Jan 9, 2012
  1. Fix for proxy when adapter modifies the passed config

    matsadler committed Jan 9, 2012
    In the case of a badly behaving connection adapter that modifies the configuration hash it is given, it is possible for a Octopus::Proxy instance to be initialized with an invalid configuration hash.
    
    Using Octopus in a threaded environment causes a new Octopus::Proxy to be created for each thread (see Octopus::Model#connection_proxy).
    
    A badly behaving adapter may alter the configuration hash passed to it.
    
    As the configuration hash for is memoized and reused an Octopus::Proxy instance will be initialized with an invalid configuration hash in threads subsequent to the first, failing with the error "Please install the  adapter: `gem install activerecord--adapter` (cannot load such file -- active_record/connection_adapters/_adapter)" when the "adapter" key can not be found in the hash.
    
    To avoid this happening the config hash is duplicated before handing to the connection adapter.