Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Branch: master
Commits on Jun 8, 2015
  1. @ogizanagi
  2. bug #14623 [Console] SymfonyStyle : fix & automate block gaps. (ogiza…

    authored
    …nagi)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Console] SymfonyStyle : fix & automate block gaps.
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    ---
    Depends on symfony#14741
    
    ---
    ## What it does
    - autoprepend appropriate blocks (like cautions, titles, sections, ...) by the correct number of blank lines considering history.
    - handle automatically most of the SymfonyStyle guide line breaks and gaps. Fix things such as unwanted double blank lines between titles and admonitions.
    - test outputs
    - fix an issue using questions with SymfonyStyle, which should not output extra blank lines when using with a non-interactive input.
    
    ## Description
    
    `SymfonyStyle` is great, but there are some issues, mostly when using blocks (text blocks, titles and admonitions): some extra blank lines might be generated.
    
    Plus, on the contrary, some line breaks or blank lines around blocks are missing, and the developer need to handle this himself by polluting his code with ugly `if` and `newLine()` statements.
    
    ### Before / After :
    
    ![screenshot 2015-05-13 a 00 11 59](https://cloud.githubusercontent.com/assets/2211145/7600572/ccfa8904-f90c-11e4-999f-d89612360424.PNG)
    
    As you can see, it's still up to the developper to end his command by a blank line (unless using a block like `SymfonyStyle::success()`) in order to distinct different commands outputs more efficiently.
    
    Everything else is now handled properly, and automatically, according to the rules exposed in the symfony console style guide published some time ago by @javiereguiluz .
    Questions (not exposed in the above output) are considered as blocks, and follow, for instance, the same conditions than admonitions: 1 blank line before and after, no more (although, you'll still be able to output more blank lines yourself, using `newLine`).
    
    Commits
    -------
    
    fc598ff [Console] SymfonyStyle : fix & automate block gaps.
    260702e [Console] SymfonyStyle : Improve EOL consistency by relying on output instance
  3. feature #14903 [profiler][request toolbar] Removed route name from th…

    authored
    …e toolbar (MJBGO)
    
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [profiler][request toolbar] Removed route name from the toolbar
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #14744
    | License       | MIT
    | Doc PR        |
    
    The action block takes nearly 1/3 of the bar width which is not good.
    The controller + action names are useful but the route name less important.
    
    Before
    ![capture_before](https://cloud.githubusercontent.com/assets/8344487/8023606/325acb00-0d13-11e5-86db-ab2a08242227.PNG)
    
    After
    ![capture_after](https://cloud.githubusercontent.com/assets/8344487/8023580/908edc22-0d11-11e5-92bd-37b380cc3433.PNG)
    
    The route name is shown by hovering the action block
    ![capture_tooltip](https://cloud.githubusercontent.com/assets/8344487/8023584/a5ae08f8-0d11-11e5-97a5-ffec6d3e41cc.PNG)
    
    Commits
    -------
    
    9004e29 Removed route name from the debugbar.
  4. feature #14904 [toolbar] Merged colored icons in toolbar (MJBGO)

    authored
    This PR was squashed before being merged into the 2.8 branch (closes #14904).
    
    Discussion
    ----------
    
    [toolbar] Merged colored icons in toolbar
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Status icons are doubled without any apparent reason.
    
    Token before
    ![capture_token_before](https://cloud.githubusercontent.com/assets/8344487/8023946/203c6fc8-0d22-11e5-9d8f-2760bfdf0c18.PNG)
    
    Token after
    ![capture_token_after](https://cloud.githubusercontent.com/assets/8344487/8024004/d0f4e9b6-0d23-11e5-9263-dd2a38b14d12.PNG)
    
    Security before
    ![capture_security_before](https://cloud.githubusercontent.com/assets/8344487/8023949/2441d6ee-0d22-11e5-9fed-168d850633d2.PNG)
    
    Security after
    ![capture_security_after](https://cloud.githubusercontent.com/assets/8344487/8023950/2444a1da-0d22-11e5-9c8a-1deb654e7ac4.PNG)
    
    Commits
    -------
    
    5b67bbd [toolbar] Merged colored icons in toolbar
  5. @MJBGO

    [toolbar] Merged colored icons in toolbar

    MJBGO authored committed
  6. minor #14905 [DX][Form] Show the class name when the deprecated setDe…

    authored
    …faultOptions is used (peterrehm)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [DX][Form] Show the class name when the deprecated setDefaultOptions is used
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    After upgrading to 2.7 I got plenty of deprecation messages which I could not assign directly as I have updated all of my FormTypes.
    
    ![bildschirmfoto 2015-06-07 um 12 02 22](https://cloud.githubusercontent.com/assets/2010989/8024784/8108aeee-0d0d-11e5-8f24-415c553ccb4c.png)
    
    Whit this minor improvement the actual class will be show so the upgrade will be much easier.
    
    ![bildschirmfoto 2015-06-07 um 12 01 24](https://cloud.githubusercontent.com/assets/2010989/8024788/93ff37d4-0d0d-11e5-8689-c3e8a933102b.png)
    
    I think same should be considered in other deprecation errors as it gets more difficult to trace down if external libraries are involved.
    
    Commits
    -------
    
    a276eb0 Show the FormType and FormTypeExtension in case of deprecated use of setDefaultOptions
  7. minor #14911 [Validator] remove partial deprecation annotation (xabbuh)

    authored
    This PR was merged into the 2.6 branch.
    
    Discussion
    ----------
    
    [Validator] remove partial deprecation annotation
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #14815
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    b49c82f [Validator] remove partial deprecation annotation
  8. @xabbuh
  9. minor #14866 Updated UPGRADE-2.4.md (mickaelandrieu)

    authored
    This PR was submitted for the 2.8 branch but it was merged into the 2.6 branch instead (closes #14866).
    
    Discussion
    ----------
    
    Updated UPGRADE-2.4.md
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | [no]
    | New feature?  | [no]
    | BC breaks?    | [no]
    | Deprecations? | [yes ?]
    | Tests pass?   | [yes]
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    A missing deprecation in the upgrade guide.
    
    Commits
    -------
    
    b631a56 Updated UPGRADE-2.4.md
  10. @mickaelandrieu

    Updated UPGRADE-2.4.md

    mickaelandrieu authored committed
  11. minor #14909 added missing " (OskarStark)

    authored
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    added missing "
    
    Commits
    -------
    
    1baf05a added missing "
  12. bug #14895 [Form] Support DateTimeImmutable in transform() (c960657)

    authored
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [Form] Support DateTimeImmutable in transform()
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    When passing a DateTimeImmutable instance to DateTimeToLocalizedStringTransformer::transform($dateTime), it throws an exception, `TransformationFailedException('Expected a \DateTime.')`.
    
    The method just converts a date-time object into a string, so there is no reason that it should not support all DateTimeInterface implementations.
    
    DateTimeInterface was added in PHP 5.5, so in order to support earlier versions, we need to do instanceof checks for both DateTime and DateTimeInterface. When Symfony requires PHP 5.5 or larger, we can remove the DateTime check and only check for DateTimeInterface.
    
    This was originally submitted as a PR against the 2.7 branch in #14676.
    
    Commits
    -------
    
    17346c5 [Form] Support DateTimeImmutable in transform()
  13. @OskarStark

    added missing "

    OskarStark authored
  14. @reecefowell
  15. @c960657
Commits on Jun 7, 2015
  1. @peterrehm
  2. minor #14901 [Form] add test to avoid regression of #14891 (xabbuh)

    authored
    This PR was merged into the 2.6 branch.
    
    Discussion
    ----------
    
    [Form] add test to avoid regression of #14891
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #14891
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    12a19c8 [Form] add test to avoid regression of #14891
  3. minor #14902 [FrameworkBundle] Document form.csrf_provider service de…

    authored
    …precation (jakzal)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] Document form.csrf_provider service deprecation
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #14899
    | License       | MIT
    | Doc PR        | -
    
    `form.csrf_provider` was deprecated in #9216.
    
    Commits
    -------
    
    0fea66f [FrameworkBundle] Document form.csrf_provider service deprecation
  4. @MJBGO
  5. @jakzal
  6. @xabbuh
Commits on Jun 6, 2015
  1. minor #14896 [Form] Fix call to removed method (BC broken in 2.3) (ta…

    authored
    …ueres)
    
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [Form] Fix call to removed method (BC broken in 2.3)
    
    ResolvedFormType#getTypeExtensions() was calling method
    AbstractType#getExtensions() which has been removed in
    commit b3081e8
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    fa9da42 [Form] Fix call to removed method (BC broken in 2.3)
  2. bug #14891 without this change allways the legacy code get called (do…

    authored
    …minikzogg)
    
    This PR was submitted for the 2.8 branch but it was merged into the 2.6 branch instead (closes #14891).
    
    Discussion
    ----------
    
    without this change allways the legacy code get called
    
    [Form] [Validator] prevent that always the legacy validator logic get called
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | [yes]
    | New feature?  | [no]
    | BC breaks?    | [no]
    | Deprecations? | [no]
    | Tests pass?   | [yes]
    | Fixed tickets | []
    | License       | MIT
    | Doc PR        | []
    
    Commits
    -------
    
    96a30bf without this change allways the legacy code get called
  3. @dominikzogg
  4. @taueres

    [Form] Fix call to removed method (BC broken in 2.3)

    taueres authored
    ResolvedFormType#getTypeExtensions() was calling method
    AbstractType#getExtensions() which has been removed in
    commit b3081e8
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
  5. bug #14888 [Console] Fix ask and askHidden methods (dosten)

    authored
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Console] Fix ask and askHidden methods
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #14885
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    5bb2cc8 Fix ask and askHidden methods
Commits on Jun 5, 2015
  1. @dosten

    Fix ask and askHidden methods

    dosten authored
  2. minor #14738 [HttpFoundation] Get response content as resource severa…

    authored
    …l times for PHP >= 5.6 (dunglas)
    
    This PR was squashed before being merged into the 2.3 branch (closes #14738).
    
    Discussion
    ----------
    
    [HttpFoundation] Get response content as resource several times for PHP >= 5.6
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    Since PHP 5.6, `php://input` can be opened several times.
    
    Commits
    -------
    
    9f9b0f7 [HttpFoundation] Get response content as resource several times for PHP >= 5.6
  3. @dunglas

    [HttpFoundation] Get response content as resource several times for P…

    dunglas authored committed
    …HP >= 5.6
  4. minor #14884 Change error message to reflect SecurityContext deprecat…

    authored
    …ion. (nickbyfleet)
    
    This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #14884).
    
    Discussion
    ----------
    
    Change error message to reflect SecurityContext deprecation.
    
    This PR was submitted on the symfony/Security read-only repository by @nickbyfleet and moved automatically to the main Symfony repository (closes symfony/Security#6).
    
    Commits
    -------
    
    4212bda Change error message to reflect SecurityContext deprecation.
  5. @nickbyfleet
  6. fixed merge

    authored
  7. Merge branch '2.6' into 2.7

    authored
    * 2.6:
      Issue #14815
  8. minor #14819 [Yaml] [Validator] Removed conditional @deprecated tags …

    authored
    …and moved their descriptions to the method description as a note (gerritdrost)
    
    This PR was submitted for the 2.7 branch but it was merged into the 2.6 branch instead (closes #14819).
    
    Discussion
    ----------
    
    [Yaml] [Validator] Removed conditional @deprecated tags and moved their descriptions to the method description as a note
    
    [Yaml] [Validator] Removed conditional @deprecated tags and moved their descriptions to the method description as a note.
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #14815
    | License       | MIT
    
    Commits
    -------
    
    17b4251 Issue #14815
  9. @gerritdrost

    Issue #14815

    gerritdrost authored committed
    Removed @deprecated tags and moved their descriptions to the method description as a note.
Something went wrong with that request. Please try again.