Skip to content

get()'s always-glob behavior stinks for unreadable directories #1201

Description

@bitprophet

Currently, get performs globbing of the filename portion in all cases (even when given a fully qualified file path).

This isn't a problem normally (though it may be somewhat inefficient) but in edge cases where the connecting user has permission to read the file, but not its enclosing directory, they encounter errors due to our attempts to listdir during the glob attempt.

I haven't looked closely but I presume we can simply test for "is this path a file?" and short circuit around globbing if that is the case; it would fix the edge case and be that much more efficient the rest of the time.

Credit to Sassa Nf (aka Alex) as per an email thread.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions