You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, get performs globbing of the filename portion in all cases (even when given a fully qualified file path).
This isn't a problem normally (though it may be somewhat inefficient) but in edge cases where the connecting user has permission to read the file, but not its enclosing directory, they encounter errors due to our attempts to listdir during the glob attempt.
I haven't looked closely but I presume we can simply test for "is this path a file?" and short circuit around globbing if that is the case; it would fix the edge case and be that much more efficient the rest of the time.
Credit to Sassa Nf (aka Alex) as per an email thread.
The text was updated successfully, but these errors were encountered:
Currently,
get
performs globbing of the filename portion in all cases (even when given a fully qualified file path).This isn't a problem normally (though it may be somewhat inefficient) but in edge cases where the connecting user has permission to read the file, but not its enclosing directory, they encounter errors due to our attempts to
listdir
during the glob attempt.I haven't looked closely but I presume we can simply test for "is this path a file?" and short circuit around globbing if that is the case; it would fix the edge case and be that much more efficient the rest of the time.
Credit to Sassa Nf (aka Alex) as per an email thread.
The text was updated successfully, but these errors were encountered: