Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get()'s always-glob behavior stinks for unreadable directories #1201

Closed
bitprophet opened this issue Oct 2, 2014 · 1 comment
Closed

get()'s always-glob behavior stinks for unreadable directories #1201

bitprophet opened this issue Oct 2, 2014 · 1 comment
Labels
Milestone

Comments

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Oct 2, 2014

Currently, get performs globbing of the filename portion in all cases (even when given a fully qualified file path).

This isn't a problem normally (though it may be somewhat inefficient) but in edge cases where the connecting user has permission to read the file, but not its enclosing directory, they encounter errors due to our attempts to listdir during the glob attempt.

I haven't looked closely but I presume we can simply test for "is this path a file?" and short circuit around globbing if that is the case; it would fix the edge case and be that much more efficient the rest of the time.

Credit to Sassa Nf (aka Alex) as per an email thread.

@bitprophet bitprophet added this to the 1.8.6/1.9.2 milestone Oct 2, 2014
@bitprophet
Copy link
Member Author

@bitprophet bitprophet commented Nov 11, 2014

This is biting other users on IRC as well.

bitprophet added a commit that referenced this issue Dec 19, 2014
bitprophet added a commit that referenced this issue Dec 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.