get()'s always-glob behavior stinks for unreadable directories #1201

Closed
bitprophet opened this Issue Oct 2, 2014 · 1 comment

Projects

None yet

1 participant

@bitprophet
Member

Currently, get performs globbing of the filename portion in all cases (even when given a fully qualified file path).

This isn't a problem normally (though it may be somewhat inefficient) but in edge cases where the connecting user has permission to read the file, but not its enclosing directory, they encounter errors due to our attempts to listdir during the glob attempt.

I haven't looked closely but I presume we can simply test for "is this path a file?" and short circuit around globbing if that is the case; it would fix the edge case and be that much more efficient the rest of the time.

Credit to Sassa Nf (aka Alex) as per an email thread.

@bitprophet bitprophet added this to the 1.8.6/1.9.2 milestone Oct 2, 2014
@bitprophet
Member

This is biting other users on IRC as well.

@bitprophet bitprophet added a commit that referenced this issue Dec 19, 2014
@bitprophet bitprophet Failing test proving #1201 1028b25
@bitprophet bitprophet added a commit that referenced this issue Dec 19, 2014
@bitprophet bitprophet Changelog re #1201 7150caf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment