Doc enhancement for fabric.operations.get mode kwarg #1325

Closed
mjmare opened this Issue Apr 26, 2015 · 3 comments

Projects

None yet

2 participants

@mjmare
mjmare commented Apr 26, 2015

The docs indicate that "Alternately, you may use the mode kwarg to specify an exact mode, in the same vein as os.chmod or the Unix chmod command."
The docs should point out that a four-digit mode mask must be provided. Three-digit mask or letter mask (like u+x) are not allowed or yield the wrong result, whereas the chmod command does allow these

@bitprophet
Member

Sounds like maybe we want to just drop the "or the Unix chmod command" part, since os.chmod does seem to only accept the 4-digit numeric value. Sound good?

@bitprophet bitprophet added the Support label May 5, 2015
@mjmare
mjmare commented May 5, 2015

That's OK, though you might want to indicate that a 4-digit value is expected. Maybe with an example.

@bitprophet
Member

Fair.

@bitprophet bitprophet added this to the 1.9.3 et al milestone May 5, 2015
@bitprophet bitprophet added a commit that referenced this issue Jun 19, 2015
@bitprophet bitprophet Changelog re #1325 8ffedda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment