Fixes #1348: handle % chars in get() in a better way #1361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ote path when using sftp get()
|
Had to cherry-pick due to changelog moving between 1.5 and 1.10, but this is merged to 1.10 and up now. (Release soon.) EDIT: yea github still doesn't see those, not surprising. It's e2ca3fd. (I tweaked the changelog entry too.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the regex for escaping the % characters.
I put this against 1.5 as that's the earliest branch I could find this in (the contributions guide said to do this), and it still persists in master. The changelog file has moved location in master, so if you want me to change anything let me know. :)