Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Group to pass on arbitrary constructor kwargs to its Connections #1831

Closed
bitprophet opened this issue Jul 24, 2018 · 0 comments
Closed

Allow Group to pass on arbitrary constructor kwargs to its Connections #1831

bitprophet opened this issue Jul 24, 2018 · 0 comments
Labels
Milestone

Comments

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Jul 24, 2018

Triggered by a mailing list post - Group is still very early days but it can't currently generate "useful" Connections with arbitrary kwargs, such as connect_kwargs. It's either Connection-first-posarg strings, or full on, manually generated Connections (to .from_connections).

The latter may still be somewhat useful (you still get a group object to pass around more easily, and its methods still yield grouped results, etc) but it feels pretty silly and is certainly extra boilerplate (list comprehensions, Connection constructors, etc).

We should add **kwargs to Group.__init__ and pass it into the Connection constructors within, at the very least. Then do the usual stripping-out of any Group-specific kwargs as we grow them.

@bitprophet bitprophet added this to the p1 milestone Jul 24, 2018
bitprophet added a commit that referenced this issue Jul 24, 2018
bitprophet added a commit that referenced this issue Jul 24, 2018
@bitprophet bitprophet closed this Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.