Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Allow Group to pass on arbitrary constructor kwargs to its Connections #1831
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Triggered by a mailing list post - Group is still very early days but it can't currently generate "useful" Connections with arbitrary kwargs, such as
connect_kwargs. It's either Connection-first-posarg strings, or full on, manually generated Connections (to.from_connections).The latter may still be somewhat useful (you still get a group object to pass around more easily, and its methods still yield grouped results, etc) but it feels pretty silly and is certainly extra boilerplate (list comprehensions, Connection constructors, etc).
We should add
**kwargstoGroup.__init__and pass it into theConnectionconstructors within, at the very least. Then do the usual stripping-out of any Group-specific kwargs as we grow them.