New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group.get needs to allow parameterized local filenames to avoid overwriting #1868
Comments
I'm hoping this is in the upgrade doc because yes, it's a clear missing feature from v1 :) EDIT: it is not in that doc! I'll add a line item and I think this may be the "TODO" ticket for this particular aspect of the feature so I'll tweak the desc. |
We'll probably want to honor how v1 did this (which I was just in the middle of reinventing myself before I edited this comment...sigh) which is tl;dr an interpolated string config value, handed a bunch of values for parameterization (remote basename and pathname, connection object params, etc). Main diff would be that we should hand in just a |
Thanks. I checked the document multiple times for this feature and couldn't find it anywhere. Many thanks for acknowledging and updating the PR + docs. I'm not fussed, long as there is a nice way with the new API to use it I'll be super happy. Also happy to try and help, but prob getting up to speed might take a bit of time. |
Linking this to #1810 (Group.get/put) where it obviously becomes pretty necessary. Will see what shakes out. I'd prefer to solve it generically but may end up having to solve it for Group specifically first. |
Thinking out loud. v1's behavior:
My gut says that for an initial port to v2, I want to do a MVP and not have it take a bunch of extra time to be 100%, if we can just add the remainder later on in compatible fashion. We also want to take the opportunity to revisit the above decisions.
|
That's a lot of words. What is the shakeout?
|
Implemented the above. There's no useful pathy bits in Paramiko and we were already applying I did also do auto-mkdir using |
Will be out in 2.6, ideally today. |
Note for completion: ended up having to s/os.makedirs/pathib.Path.mkdir/ as the former was just too limited. |
Hi,
I'd like to be able to .get() on a ThreadingGroup and have the hostname/ip/somethingunique added to the
dst
filename so I can get the same file from multiple hosts.Sorry if I missed it, but I can not see a clean way to move to:
from
Please merge or propose workaround if they exist! Thanks.
The text was updated successfully, but these errors were encountered: