Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Paramiko exec_command's 'timeout' kwarg #1922

Closed
yvwulei opened this issue Jan 3, 2019 · 3 comments
Closed

Add support for Paramiko exec_command's 'timeout' kwarg #1922

yvwulei opened this issue Jan 3, 2019 · 3 comments

Comments

@yvwulei
Copy link

yvwulei commented Jan 3, 2019

How to use command_timeout in fabric2.4

Thanks first.

@bitprophet bitprophet changed the title How to use command_timeout in fabric2.4 Add support for Paramiko exec_command's 'timeout' kwarg Jan 8, 2019
@bitprophet bitprophet added this to the p2 milestone Jan 8, 2019
@bitprophet
Copy link
Member

This has been an in-code TODO for a while:

fabric/fabric/runners.py

Lines 30 to 31 in e9939d6

# TODO: pass in timeout= here when invoke grows timeout functionality
# in Runner/Local.

The "real" ticket for this is at the command-runner (Invoke) layer: pyinvoke/invoke#539

The code Fabric's level of things needs to be tickling, in Paramiko, is: https://github.com/paramiko/paramiko/blob/cf7d49d66f3b1fbc8b0853518a54050182b3b5eb/paramiko/client.py#L463

@bitprophet
Copy link
Member

See #539 / #645

@mcouthon
Copy link

After reading pyinvoke/invoke#539, I see that this was solved in invoke, but AFAICT, the code in fabric's master branch still does not pass the timeout param to command_exec.
Does this mean that this ability is only available when running fabric through the CLI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants