Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support closing remote subprocess' stdin explicitly #1985

Closed
bitprophet opened this issue Jun 14, 2019 · 2 comments
Closed

Support closing remote subprocess' stdin explicitly #1985

bitprophet opened this issue Jun 14, 2019 · 2 comments

Comments

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Jun 14, 2019

This is covered by pyinvoke/invoke#552 and requires it (specifically, its support for adding a Runner.close_proc_stdin method - so this happens to be backwards compatible insofar as it won't error on older Invoke versions).

Just making this so I've got something for the changelog really.

@bitprophet
Copy link
Member Author

@bitprophet bitprophet commented Jul 19, 2019

TODO: run tests on travis after Invoke 1.3.0 is released.

Loading

bitprophet added a commit that referenced this issue Aug 4, 2019
bitprophet added a commit that referenced this issue Aug 6, 2019
@bitprophet
Copy link
Member Author

@bitprophet bitprophet commented Aug 6, 2019

As seen in #1989 I just sucked it up for now and added master-invoke to our dev-requirements.txt, so that Travis will test against that branch instead of latest-public-release.

Tests seem to pass, so this is done for reals now I think.

Loading

@bitprophet bitprophet closed this Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant