Allow new values in settings context manager. #252

Closed
bitprophet opened this Issue Aug 19, 2011 · 2 comments

Projects

None yet

1 participant

@bitprophet
Member

Description

Hi all-

Currently, settings() can only override values already set in env. This seems to be an arbitrary limitation, so the


Originally submitted by Will Maier (wcmaier) on 2010-11-11 at 02:47pm EST

Attachments

@bitprophet bitprophet was assigned Aug 19, 2011
@bitprophet
Member

Jeff Forcier (bitprophet) posted:


Good catch -- that limitation is definitely not on purpose.


on 2010-11-11 at 02:49pm EST

@bitprophet
Member

Will Maier (wcmaier) posted:


(Sigh; hit Enter when I shouldn't have.)

...This seems to be an arbitrary limitation, so the attached patches remove it. settings-0.patch adds a basic test of settings() functionality; settings-1.patch allows new values to be set. Both changes are included in my github fork.

Thanks!


on 2010-11-11 at 02:50pm EST

@bitprophet bitprophet closed this in b19c923 Sep 1, 2011
@ramonvanalteren ramonvanalteren added a commit to ramonvanalteren/fabric that referenced this issue Sep 2, 2011
@ramonvanalteren ramonvanalteren Merge branch 'master' into multiprocessing-lib
* master: (94 commits)
  Cut 1.2.2
  Cut 1.1.4
  Cut 1.0.4
  Allow the settings contextmanager to set new env keys. Fixes #252
  Fix import typo in task usage docs. Fixes #393
  Flip "listing commands" flag in main.py if `--shortlist` is given.
  Update changelog re #373. Fixes #373.
  Docs and tests re #373
  Reference exclude_hosts kwarg when merging decorator-driven host lists
  Actually, don't look for excude_hosts kwarg when determining how to merge host lists -- doesn't make much sense.
  Add cli-kwarg test for host exclusion, re #373
  There is no function-attr anywhere for exclude_hosts, so don't check for one.
  Merge hosts at CLI-kwarg level if exclude_hosts kwarg is present.
  Actually exclude hosts when merging host lists.
  Formatting
  Check stdout instead of stdin for tty-ness when sizing up local terminal.
  Formatting
  Dev version
  Dev version
  Dev version
  ...

Conflicts:
	fabric/decorators.py
	fabric/tasks.py
	tests/test_decorators.py
b41a5c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment