Skip to content

Allow new values in settings context manager. #252

Description

@bitprophet

Description

Hi all-

Currently, settings() can only override values already set in env. This seems to be an arbitrary limitation, so the


Originally submitted by Will Maier (wcmaier) on 2010-11-11 at 02:47pm EST

Attachments

Activity

  1. bitprophet commented on Aug 19, 2011

    @bitprophet
    MemberAuthor

    Jeff Forcier (bitprophet) posted:


    Good catch -- that limitation is definitely not on purpose.


    on 2010-11-11 at 02:49pm EST

  2. bitprophet commented on Aug 19, 2011

    @bitprophet
    MemberAuthor

    Will Maier (wcmaier) posted:


    (Sigh; hit Enter when I shouldn't have.)

    ...This seems to be an arbitrary limitation, so the attached patches remove it. settings-0.patch adds a basic test of settings() functionality; settings-1.patch allows new values to be set. Both changes are included in my github fork.

    Thanks!


    on 2010-11-11 at 02:50pm EST

  3. added a commit that references this issue on Sep 2, 2011
    b41a5c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions