Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Excluding hosts is broken #373

Closed
bitprophet opened this Issue Aug 19, 2011 · 0 comments

Comments

Projects
None yet
1 participant
Owner

bitprophet commented Aug 19, 2011

Description

While the tests for this newly added feature still pass, the feature itself is broken in real usage:

  • fab -x doesn't work with -H-specified hosts (also when @hosts is used)
  • fab -x doesn't work with -R specified roles (also when @roles is used)
  • fab task:exclude_hosts=x doesn't work with -H-specified hosts (when @roles is used, but also when it is not used)

The rest may be busted too, not sure. Haven't actually looked at the cause, hopefully something simple was busted pre-1.1 release.


Originally submitted by Jeff Forcier (bitprophet) on 2011-07-05 at 12:55am EDT

@bitprophet bitprophet was assigned Aug 19, 2011

@bitprophet bitprophet added a commit that referenced this issue Aug 31, 2011

@bitprophet bitprophet Docs and tests re #373 5a58b37

@bitprophet bitprophet closed this in 06cd63e Sep 1, 2011

@ramonvanalteren ramonvanalteren added a commit to ramonvanalteren/fabric that referenced this issue Sep 2, 2011

@ramonvanalteren ramonvanalteren Merge branch 'master' into multiprocessing-lib
* master: (94 commits)
  Cut 1.2.2
  Cut 1.1.4
  Cut 1.0.4
  Allow the settings contextmanager to set new env keys. Fixes #252
  Fix import typo in task usage docs. Fixes #393
  Flip "listing commands" flag in main.py if `--shortlist` is given.
  Update changelog re #373. Fixes #373.
  Docs and tests re #373
  Reference exclude_hosts kwarg when merging decorator-driven host lists
  Actually, don't look for excude_hosts kwarg when determining how to merge host lists -- doesn't make much sense.
  Add cli-kwarg test for host exclusion, re #373
  There is no function-attr anywhere for exclude_hosts, so don't check for one.
  Merge hosts at CLI-kwarg level if exclude_hosts kwarg is present.
  Actually exclude hosts when merging host lists.
  Formatting
  Check stdout instead of stdin for tty-ness when sizing up local terminal.
  Formatting
  Dev version
  Dev version
  Dev version
  ...

Conflicts:
	fabric/decorators.py
	fabric/tasks.py
	tests/test_decorators.py
b41a5c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment