Excluding hosts is broken #373
Milestone
Comments
ghost
assigned
bitprophet
added a commit
that referenced
this issue
Aug 31, 2011
bitprophet
added a commit
that referenced
this issue
Aug 31, 2011
bitprophet
added a commit
that referenced
this issue
Aug 31, 2011
bitprophet
added a commit
that referenced
this issue
Aug 31, 2011
ramonvanalteren
added a commit
to ramonvanalteren/fabric
that referenced
this issue
Sep 2, 2011
* master: (94 commits) Cut 1.2.2 Cut 1.1.4 Cut 1.0.4 Allow the settings contextmanager to set new env keys. Fixes fabric#252 Fix import typo in task usage docs. Fixes fabric#393 Flip "listing commands" flag in main.py if `--shortlist` is given. Update changelog re fabric#373. Fixes fabric#373. Docs and tests re fabric#373 Reference exclude_hosts kwarg when merging decorator-driven host lists Actually, don't look for excude_hosts kwarg when determining how to merge host lists -- doesn't make much sense. Add cli-kwarg test for host exclusion, re fabric#373 There is no function-attr anywhere for exclude_hosts, so don't check for one. Merge hosts at CLI-kwarg level if exclude_hosts kwarg is present. Actually exclude hosts when merging host lists. Formatting Check stdout instead of stdin for tty-ness when sizing up local terminal. Formatting Dev version Dev version Dev version ... Conflicts: fabric/decorators.py fabric/tasks.py tests/test_decorators.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
While the tests for this newly added feature still pass, the feature itself is broken in real usage:
fab -xdoesn't work with-H-specified hosts (also when@hostsis used)fab -xdoesn't work with-Rspecified roles (also when@rolesis used)fab task:exclude_hosts=xdoesn't work with-H-specified hosts (when@rolesis used, but also when it is not used)The rest may be busted too, not sure. Haven't actually looked at the cause, hopefully something simple was busted pre-1.1 release.
Originally submitted by Jeff Forcier (bitprophet) on 2011-07-05 at 12:55am EDT
The text was updated successfully, but these errors were encountered: