s/str/basestring/ #380

Closed
bitprophet opened this Issue Aug 19, 2011 · 1 comment

Projects

None yet

1 participant

@bitprophet
Member

Description

Instead of comparing with str or types.StringTypes, use basestring instead -- it's newer and easier to use, being a builtin.

GH commit from Jiri Barton.


Originally submitted by Jeff Forcier (bitprophet) on 2011-07-07 at 03:35pm EDT


Closed as Done on 2011-07-08 at 07:36pm EDT

@bitprophet bitprophet was assigned Aug 19, 2011
@bitprophet
Member

Jeff Forcier (bitprophet) posted:


Applied in changeset commit:fa730cda1ab32922966afed7bb2b137768009092.


on 2011-07-08 at 07:36pm EDT

@bitprophet bitprophet closed this Aug 19, 2011
@cyberj cyberj pushed a commit to bearstech/fabric that referenced this issue Aug 22, 2011
@bitprophet bitprophet When detecting strings vs other types, use basestring.
Fixes #380
fa730cd
@cyberj cyberj pushed a commit to bearstech/fabric that referenced this issue Aug 22, 2011
@bitprophet bitprophet Changelog re #380 86245e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment