Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s/str/basestring/ #380

Closed
bitprophet opened this issue Aug 19, 2011 · 1 comment
Closed

s/str/basestring/ #380

bitprophet opened this issue Aug 19, 2011 · 1 comment
Labels

Comments

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Aug 19, 2011

Description

Instead of comparing with str or types.StringTypes, use basestring instead -- it's newer and easier to use, being a builtin.

GH commit from Jiri Barton.


Originally submitted by Jeff Forcier (bitprophet) on 2011-07-07 at 03:35pm EDT


Closed as Done on 2011-07-08 at 07:36pm EDT

@ghost ghost assigned bitprophet Aug 19, 2011
@bitprophet
Copy link
Member Author

@bitprophet bitprophet commented Aug 19, 2011

Jeff Forcier (bitprophet) posted:


Applied in changeset commit:fa730cda1ab32922966afed7bb2b137768009092.


on 2011-07-08 at 07:36pm EDT

@bitprophet bitprophet closed this Aug 19, 2011
cyberj pushed a commit to bearstech/fabric that referenced this issue Aug 22, 2011
cyberj pushed a commit to bearstech/fabric that referenced this issue Aug 22, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.