New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong import in Defining tasks webpage. #393

Closed
bitprophet opened this Issue Aug 19, 2011 · 4 comments

Comments

Projects
None yet
1 participant
@bitprophet
Member

bitprophet commented Aug 19, 2011

Description

The first example for using the @task decorator has an incorrect import.

http://docs.fabfile.org/en/1.2.0/usage/tasks.html

It has:
from fabric.api import tasks, run

When it should be:
from fabric.api import tasks, run


Originally submitted by Hugo Garza (hiro2k) on 2011-07-20 at 01:02pm EDT

@ghost ghost assigned bitprophet Aug 19, 2011

@bitprophet

This comment has been minimized.

Member

bitprophet commented Aug 19, 2011

Hugo Garza (hiro2k) posted:


Doh! My proposed fixed didn't remove the extra s.

It should be: from fabric.api import task, run


on 2011-07-20 at 01:03pm EDT

@bitprophet

This comment has been minimized.

Member

bitprophet commented Aug 19, 2011

Jeff Forcier (bitprophet) posted:


Thanks, good catch!


on 2011-07-20 at 02:17pm EDT

@bitprophet

This comment has been minimized.

Member

bitprophet commented Aug 19, 2011

Morgan Goose (goosemo) posted:


Had Siraaj cut his commit teeth on this issue, and he's made a pull request for it.


on 2011-07-31 at 08:55pm EDT

@bitprophet

This comment has been minimized.

Member

bitprophet commented Aug 23, 2011

@goosemo unless it's in another ticket somewhere, the pull request would have been overwritten in the migration -- what's Siraaj's github url? have him link to the commit/branch in question in a comment here please. (not a new pull request!)

@bitprophet bitprophet closed this in 3633bee Sep 1, 2011

ramonvanalteren added a commit to ramonvanalteren/fabric that referenced this issue Sep 2, 2011

Merge branch 'master' into multiprocessing-lib
* master: (94 commits)
  Cut 1.2.2
  Cut 1.1.4
  Cut 1.0.4
  Allow the settings contextmanager to set new env keys. Fixes fabric#252
  Fix import typo in task usage docs. Fixes fabric#393
  Flip "listing commands" flag in main.py if `--shortlist` is given.
  Update changelog re fabric#373. Fixes fabric#373.
  Docs and tests re fabric#373
  Reference exclude_hosts kwarg when merging decorator-driven host lists
  Actually, don't look for excude_hosts kwarg when determining how to merge host lists -- doesn't make much sense.
  Add cli-kwarg test for host exclusion, re fabric#373
  There is no function-attr anywhere for exclude_hosts, so don't check for one.
  Merge hosts at CLI-kwarg level if exclude_hosts kwarg is present.
  Actually exclude hosts when merging host lists.
  Formatting
  Check stdout instead of stdin for tty-ness when sizing up local terminal.
  Formatting
  Dev version
  Dev version
  Dev version
  ...

Conflicts:
	fabric/decorators.py
	fabric/tasks.py
	tests/test_decorators.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment