rsync port is reset when using @parallel

[robbyt]

When I use rsync_project() in a task that is running under @parellel, I receive the following error:

Bad port 'None'
rsync: connection unexpectedly closed (0 bytes received so far) [sender]
rsync error: unexplained error (code 255) at io.c(601) [sender=3.0.7]

Fatal error: local() encountered an error (return code 255) while executing 'rsync --delete --exclude ".git" -pthrvz --rsync-path='sudo rsync' --rsh='ssh -p None ' /source/ rterhaar@server:/destination/'

Aborting.

However, running non-parallel works fine.

[bitprophet]

Hm, it's odd that parallel makes this not work, offhand I don't see why it'd cause problems. I'll have to look into it, hopefully it will be reproducible on my end.

Do you have a copy of the fabfile code causing this?

---

It's possible this is also related to #445 though that makes no mention of the parallel angle. I may tackle both at the same time.

[robbyt]

The fabric code is (admittedly...) pretty complicated. There is a task which instantiates a class(object), which calls a function. I will try to write a simple test to see if I can recreate where the rsync code breaks down.

task => class instance => function => rsync

[robbyt]

Came up with a simple test case that illustrates this problem. The following two tasks will return different values. Both should print '22', however when @parallel is enabled, it prints None.

from fabric.colors import cyan
from fabric.api import *

@task
#@parallel
@roles('webapp')
def tester():
    print cyan(env.port)

vs.

from fabric.colors import cyan
from fabric.api import *

@task
@parallel
@roles('webapp')
def tester():
    print cyan(env.port)

[bitprophet]

Thanks; could be that env.port is generally getting unset when parallel mode is enabled (since handing off the tasks to subprocesses involves a "clean" copy of the env, IIRC, which might be a buggy process.) Will look.