New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow display of full stack trace on error #52

Closed
bitprophet opened this Issue Aug 19, 2011 · 3 comments

Comments

Projects
None yet
1 participant
@bitprophet
Member

bitprophet commented Aug 19, 2011

Description

Right now we just print out the exception message; that should probably still be the default, but add an option for spitting out the entire stack trace as usual. Since this behavior is the same for aborts and warns, possibly best to use the stdlib functions which print stack traces, instead of just raise-ing.


Originally submitted by Jeff Forcier (bitprophet) on 2009-08-14 at 09:59am EDT

Relations

  • Related to #51: Handle Paramiko-level "logger" issues

Closed as Done on 2009-11-08 at 11:31am EST

@ghost ghost assigned bitprophet Aug 19, 2011

@bitprophet

This comment has been minimized.

Show comment
Hide comment
@bitprophet

bitprophet Aug 19, 2011

Member

Anonymous () posted:


Doesn't raise always give a traceback?


on 2009-08-14 at 01:03pm EDT

Member

bitprophet commented Aug 19, 2011

Anonymous () posted:


Doesn't raise always give a traceback?


on 2009-08-14 at 01:03pm EDT

@bitprophet

This comment has been minimized.

Show comment
Hide comment
@bitprophet

bitprophet Aug 19, 2011

Member

Anonymous () posted:


Did you read the whole paragraph in the description? :) I'd like this to work for both aborts (program exits, so raise would work OK here) and warns (program continues running, so raise would not work OK here.)

So, raise is the quick and dirty approach, but I'd rather use the safer approach of printing some data from the traceback module.

(Yes, we could have the logic read "if aborting, then just raise, otherwise print traceback and continue" but at that point it's actually less code to just print the traceback either way :))


on 2009-08-14 at 01:33pm EDT

Member

bitprophet commented Aug 19, 2011

Anonymous () posted:


Did you read the whole paragraph in the description? :) I'd like this to work for both aborts (program exits, so raise would work OK here) and warns (program continues running, so raise would not work OK here.)

So, raise is the quick and dirty approach, but I'd rather use the safer approach of printing some data from the traceback module.

(Yes, we could have the logic read "if aborting, then just raise, otherwise print traceback and continue" but at that point it's actually less code to just print the traceback either way :))


on 2009-08-14 at 01:33pm EDT

@bitprophet

This comment has been minimized.

Show comment
Hide comment
@bitprophet

bitprophet Aug 19, 2011

Member

Jeff Forcier (bitprophet) posted:


Applied in changeset commit:7085e8c063b725aa55f3682c72d1501a0b212168.


on 2009-08-27 at 11:14am EDT

Member

bitprophet commented Aug 19, 2011

Jeff Forcier (bitprophet) posted:


Applied in changeset commit:7085e8c063b725aa55f3682c72d1501a0b212168.


on 2009-08-27 at 11:14am EDT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment