New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend `cd` to work for get/put #61

Closed
bitprophet opened this Issue Aug 19, 2011 · 4 comments

Comments

Projects
None yet
1 participant
@bitprophet
Member

bitprophet commented Aug 19, 2011

Description

So far I've kept cd to apply only to the shell command operations, as that made the most sense. However, after a user tried using it with get, I realized that it's surprising to users for cd to not work with the SFTP-based operations.

It should be possible to insert logic along the lines of "if remote path is not absolute, prepend env.cwd to it".

One potential pitfall is that since we did extend cd to local, it is ambiguous whether the "cd" should apply to the local or the remote path (or both!) when using get or put. Not sure what the best way to handle this is, other than a highlighted note in the docs stating that it only applies to one or the other.

Or have it apply to any path that is not absolute, though this seems odd to me -- just how often is someone going to want cd to apply to both sides at the same time?


Originally submitted by Jeff Forcier (bitprophet) on 2009-09-16 at 10:17am EDT

Relations

  • Related to #245: Consider breaking out the cd() behavior of local into lcd()
  • Related to #140: Recursive put() and get()

Closed as Done on 2011-03-09 at 10:12pm EST

@ghost ghost assigned bitprophet Aug 19, 2011

@bitprophet

This comment has been minimized.

Show comment
Hide comment
@bitprophet

bitprophet Aug 19, 2011

Member

Kenneth Reitz (kennethreitz) posted:


I agree, this would be extremely helpful.


on 2010-05-14 at 01:25pm EDT

Member

bitprophet commented Aug 19, 2011

Kenneth Reitz (kennethreitz) posted:


I agree, this would be extremely helpful.


on 2010-05-14 at 01:25pm EDT

@bitprophet

This comment has been minimized.

Show comment
Hide comment
@bitprophet

bitprophet Aug 19, 2011

Member

Erich Heine (sophacles) posted:


Note: this is affected by and affects #140


on 2010-05-14 at 03:12pm EDT

Member

bitprophet commented Aug 19, 2011

Erich Heine (sophacles) posted:


Note: this is affected by and affects #140


on 2010-05-14 at 03:12pm EDT

@bitprophet

This comment has been minimized.

Show comment
Hide comment
@bitprophet

bitprophet Aug 19, 2011

Member

Jeff Forcier (bitprophet) posted:


Thanks, Erich, you're right. Just updated the ticket relationship.


on 2010-05-14 at 07:08pm EDT

Member

bitprophet commented Aug 19, 2011

Jeff Forcier (bitprophet) posted:


Thanks, Erich, you're right. Just updated the ticket relationship.


on 2010-05-14 at 07:08pm EDT

@bitprophet

This comment has been minimized.

Show comment
Hide comment
@bitprophet

bitprophet Aug 19, 2011

Member

Jeff Forcier (bitprophet) posted:


s/re/implements/


on 2011-01-12 at 06:28pm EST

Member

bitprophet commented Aug 19, 2011

Jeff Forcier (bitprophet) posted:


s/re/implements/


on 2011-01-12 at 06:28pm EST

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment