Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Global parallelization doesn't play nice with @runs_once? #681

Closed
bitprophet opened this Issue · 3 comments

2 participants

@bitprophet
Owner

Haven't looked but suspect this is simply because the parallel machinery is unaware of @runs_once and so by the time @runs_once's memoization implementation kicks in, it's already inside its own multiprocessing subprocess, and so of course the reliance on shared state for memoization to function, means it runs once per host.

Assuming that's accurate, make the parallel machinery aware of @runs_once's desired behavior, either by looking for an existing attribute, or adding a 'hint' in @runs_once's implementation and look for that.

@bitprophet
Owner

I actually cannot replicate this now, and upon inspection, we are explicitly handling this by having @runs_once mark the decorator as serial, and have since at least 1.3.x.

@bracki I think you were the one who mentioned this on IRC; can you please confirm your instance of this bug and verify the version you're seeing it with? (And ideally how to replicate it.)

@bracki

Then it is a misunderstanding stemming from the documentation on runs_once. It explicitly warns that runs_once does not go along with parallel mode.
https://github.com/fabric/fabric/blob/master/fabric/decorators.py#L129

@bitprophet
Owner

Aha, totally missed that. It was probably added before we implemented the solution I mentioned. I'll fix that posthaste, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.