Global parallelization doesn't play nice with @runs_once?

[bitprophet]

Haven't looked but suspect this is simply because the parallel machinery is unaware of @runs_once and so by the time @runs_once's memoization implementation kicks in, it's already inside its own multiprocessing subprocess, and so of course the reliance on shared state for memoization to function, means it runs once per host.

Assuming that's accurate, make the parallel machinery aware of @runs_once's desired behavior, either by looking for an existing attribute, or adding a 'hint' in @runs_once's implementation and look for that.

[bitprophet]

I actually cannot replicate this now, and upon inspection, we are explicitly handling this by having @runs_once mark the decorator as serial, and have since at least 1.3.x.

@bracki I think you were the one who mentioned this on IRC; can you please confirm your instance of this bug and verify the version you're seeing it with? (And ideally how to replicate it.)

[bracki]

Then it is a misunderstanding stemming from the documentation on runs_once. It explicitly warns that runs_once does not go along with parallel mode.
https://github.com/fabric/fabric/blob/master/fabric/decorators.py#L129

[bitprophet]

Aha, totally missed that. It was probably added before we implemented the solution I mentioned. I'll fix that posthaste, thanks!

[daniyalzade]

Quick question here though, in the parallel mode, how can I ensure that a task is run only once, such as a cleanup task at the end of the execution?

[bitprophet]

@daniyalzade please use the mailing list or irc for that sort of question, thanks!