Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Need a "skip on prompt" option for parallel mode #714
When using parallel mode a prompt for password will default in an abort.
This is not always the desired behavior. In certain cases, it can be desired that a host prompting for something is to be considered a "bad host". Example use cases
I think a way to handle such scenario would be to have a skip_on_prompt option, usable both in serial and parallel mode. In case a prompt (of any kind) is triggered, the server is skipped and the corresponding exception is stored in the result.
I worked on an implementation for this. This can be made even simpler that I initially though, if we can accept the following assumption: "Having the password set to "None" in the env is interpreted as the intention not to be prompted for password".
With this assumption no additional flag is required, just a two lines code change, plus documentation for this assumption.
The assumption works especially well in case of parallel execution, as it avoids aborting a complete set of tasks because of a set of servers where the public key has not been successfully provisioned.
If you are interested, I have the code fix. I can work on updates for the documentation as well.
Note that I did not pass the original exception into the new NetworkException on purpose.
$ git diff