OSError running Fabric from source on non-git systems #749
Comments
|
And there's no graceful workaround for that angle, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Example:
This example comes from an Android system lacking pip or git binaries. I believe the error is legit, as we simply call
subprocess.Popen("git xxx")
, which should AFAIK blow up on any system lacking Git.Why this didn't come up before now is probably due to the following:
fab --version
(and--version
is likely rarely invoked)git_sha() or xxx
.EDIT: Except that should still result in a shell level error (eg
bash: git: file not found
) and not OSError -- so this might meant Popen itself cannot open the shell it's trying to use (should be/bin/sh
by default). Which makes a lot more sense on Android vs other systems.Fix should be a simple try/except either way.
The text was updated successfully, but these errors were encountered: