Auto-linewise is still broken? #767

Activity

1. bitprophet commented on Oct 28, 2012

   

   bitprophet

   on Oct 28, 2012

   MemberAuthor

   More actions

   I still can't replicate the symptom, but I can confirm that the tasks being run don't see env.linewise = True, so...yea.

   Guessing it's because the code setting this is a context manager wrapping the definition of the function passed into multiprocessing -- not surprised that relying on global module state could cause hijinx like this.

   What is odd is that the env.parallel = True is sticking. If the inner scope was completely ignoring the env changes I'd expect that to also be False.

   Will experiment with explicitly handing a copy of local_env down the call chain, and hope that moving things around won't sink some other edge case not under study here 😕
2. bitprophet commented on Oct 29, 2012

   

   bitprophet

   on Oct 29, 2012

   MemberAuthor

   More actions

   • Added an explicit, currently-failing test for this (re: the env var itself)
   • Implemented the above experiment re: being more direct with application of the inner fab env
   • Entire test suite now passes, including new test
   • Manual test that tried to replicate the bug still works fine for me (re: a moderately sized parallel flight running a nontrivial multiline-output command)

   I'm committing this change to the 1.4 branch and merging it into master on the assumption that it does fix the problem. Attn @shaftoe & @dmcquay if either of you are up to testing from a Git checkout :)
3. bitprophet

   added a commit that references this issue on Oct 29, 2012

   Add failing test re: linewise-when-parallel

   ...

   80be1b6
4. bitprophet

   closed this as completedin 15981b7on Oct 29, 2012
5. bitprophet

   added a commit that references this issue on Oct 29, 2012

   Changelog re #767

   a996bc7
6. dmcquay commented on Oct 29, 2012

   

   dmcquay

   on Oct 29, 2012

   More actions

   Thanks @bitprophet! I'll give this a try soon.