lcd() context with local() and CDPATH includes output of cd command #980
Labels
Comments
This is probably ok, but need to look at how |
Looks like the change would be to https://github.com/fabric/fabric/blob/1.9/fabric/operations.py#L661 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using something like
while the environment variable CDPATH is present, Bash will output what directory it ends up in the target_dir was a simple name (no slashes). The docs (for cd()) suggest that running a command ends up doing "cd target_dir && command", but if CDPATH is present the model would need to be "cd target_dir >/dev/null && command" to be reliable. Otherwise the command's output will have a generally unanticipated prefixed directory name, and horribly break some fab jobs for only certain users.
Alternatively, fab could unset CDPATH by default, and be documented as doing so, though there is a small chance some nutter is using that extra output deliberately.
The text was updated successfully, but these errors were encountered: