Fix typo on ssh.ProxyCommand #1046

Closed
wants to merge 1 commit into
from

Projects

None yet
@keitheis

On fabric 1.8.1 we got AttributeError: 'module' object has no attribute 'proxycommand' error by the typo.

fab test
[biiwork] Executing task 'test'
[biiwork] run: echo 'Done test.'
Traceback (most recent call last):
.../Python/fabric/fabric/network.py", line 99, in get_gateway
    sock = ssh.proxycommand(proxy_command)
AttributeError: 'module' object has no attribute 'proxycommand'

This patch fixed it:

fab test
[biiwork] Executing task 'test'
[biiwork] run: echo 'Done test.'
[biiwork] out: Done test.
@stormbrew

Please merge this, it's breaking things for us quite badly.

@marilsoncampos

Same here.

@DavidWittman

๐Ÿ‘

@giffels
giffels commented Jan 24, 2014

๐Ÿ‘

@mitsuhiko

๐Ÿ‘

@zbrdge
zbrdge commented Feb 2, 2014

Yeah. Agreed.

@h3
h3 commented Feb 5, 2014

๐Ÿ‘ Bump.. Seriously.

@vdemeester

๐Ÿ‘

@flozano
flozano commented Feb 11, 2014

Same here...

@mgedmin
mgedmin commented Feb 11, 2014

Downgrading to Fabric 1.8.0 fixes this for me.

Can we have 1.8.2 with this fix please?

@bitprophet
Member

Confirmed, merging into 1.7 and adding changelog. Will be out in 1.7.x and 1.8.x releases sometime today. Sorry for the delay!

@keitheis

Thank you bitprophet!

@bitprophet bitprophet added a commit that referenced this pull request Feb 14, 2014
@bitprophet bitprophet Changelog re #1046, fixes #1046 fd62430
@bitprophet bitprophet added a commit that closed this pull request Feb 14, 2014
@bitprophet bitprophet Changelog re #1046, fixes #1046 fd62430
@keitheis keitheis deleted the keitheis:ssh_proxycommand_typo branch Feb 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment