Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo on ssh.ProxyCommand #1046

Closed
wants to merge 1 commit into from

Conversation

keitheis
Copy link

On fabric 1.8.1 we got AttributeError: 'module' object has no attribute 'proxycommand' error by the typo.

fab test
[biiwork] Executing task 'test'
[biiwork] run: echo 'Done test.'
Traceback (most recent call last):
.../Python/fabric/fabric/network.py", line 99, in get_gateway
    sock = ssh.proxycommand(proxy_command)
AttributeError: 'module' object has no attribute 'proxycommand'

This patch fixed it:

fab test
[biiwork] Executing task 'test'
[biiwork] run: echo 'Done test.'
[biiwork] out: Done test.

@stormbrew
Copy link

Please merge this, it's breaking things for us quite badly.

@marilsoncampos
Copy link

Same here.

@DavidWittman
Copy link

👍

2 similar comments
@giffels
Copy link

giffels commented Jan 24, 2014

👍

@mitsuhiko
Copy link

👍

@zbrdge
Copy link

zbrdge commented Feb 2, 2014

Yeah. Agreed.

@h3
Copy link

h3 commented Feb 5, 2014

👍 Bump.. Seriously.

@vdemeester
Copy link

👍

@flozano
Copy link

flozano commented Feb 11, 2014

Same here...

@mgedmin
Copy link

mgedmin commented Feb 11, 2014

Downgrading to Fabric 1.8.0 fixes this for me.

Can we have 1.8.2 with this fix please?

@bitprophet
Copy link
Member

Confirmed, merging into 1.7 and adding changelog. Will be out in 1.7.x and 1.8.x releases sometime today. Sorry for the delay!

@keitheis
Copy link
Author

Thank you bitprophet!

@keitheis keitheis deleted the ssh_proxycommand_typo branch February 14, 2014 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet