Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to skip unknown tasks #1090

Merged
merged 2 commits into from
Sep 3, 2014

Conversation

lundberg
Copy link

@lundberg lundberg commented Mar 6, 2014

Fixes #1089

@lundberg
Copy link
Author

Failing tests are not related to this pull request

@bitprophet
Copy link
Member

This feature's small enough that I will probably merge it during the next pass of open tickets :) Thanks!

@bitprophet
Copy link
Member

Re: @humanfromearth 's comment on #1089, one response to this could also be "this should always result in an error". However, I am usually a fan of "let you shoot yourself in the foot" features provided they are 100% opt-in and don't cause too much branching in existing code, and this does fit that bill. So it's still on the table for now.

@bitprophet bitprophet added this to the 1.10 milestone Aug 6, 2014
@lundberg
Copy link
Author

Thanks!

I've rebased master and fixed conflicting changelog to #1090.

@bitprophet bitprophet merged commit d66e3a6 into fabric:master Sep 3, 2014
@lundberg lundberg deleted the skip-unknown-tasks branch September 9, 2014 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants