New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dict style roledefs #1098

Merged
merged 1 commit into from Sep 3, 2014

Conversation

Projects
None yet
2 participants
@lundberg

lundberg commented Mar 13, 2014

Fixes #1097

@bitprophet

This comment has been minimized.

Member

bitprophet commented Aug 4, 2014

First - thanks for submitting this, it's rare that contributors include changelog/docs as well as code!

Second - I've been punting on this sort of new feature until version 2.x to avoid more bloat / confusion / potential bugs in the 1.x line. However, this implementation is sufficiently compact & additive that I'm leaving it open and will likely merge after a 2nd look later. Thanks again!

@bitprophet bitprophet added this to the 1.10 milestone Aug 6, 2014

@lundberg

This comment has been minimized.

lundberg commented Aug 11, 2014

I'm the one to thank you for an awesome tool and really looking forward to 2.0.
It's a great idea to separate things up and make fabric more of a library to work/depend on.

I've been using fabric for lots of years now. All my pull requests are fragments from a wrapper that i'm calling refabric, which acts a little bit like chef and ansible in terms of configuration and blueprints/recipes.

Btw, I rebased master and resolved changelog conflict.

@bitprophet bitprophet merged commit a779c6f into fabric:master Sep 3, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@lundberg lundberg deleted the 5monkeys:dict-style-roledefs branch Sep 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment