Fixed a bug where when mirror_local_mode lcd was not obeyed. Added tests... #1146

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@atleta
atleta commented Jun 18, 2014

Fixed the bug (one liner) and created tests that do break without applying the fix and do pass with the fix. Testing all the four scenarios (with and without jinja, with and without mirroring local mode).

@collinanderson

You could use contextlib.nested() on your with statement to add python 2.6 support.

https://docs.python.org/2/library/contextlib.html#contextlib.nested

@atleta
atleta commented Jun 26, 2014

Yep, already found out about the bug, but haven't pushed yet. As contextlib.nested is deprecated in 2.7 I used two nested with statements. Is that OK with you?

Laszlo Marai Changed list of context managers in with statements into nested with
  statements so that tests pass on 2.6.
33fcbed
@atleta
atleta commented Jun 26, 2014

So I updated the pull request and now build passes.

@atleta
atleta commented Jul 19, 2014

Any updates on this one?

@bitprophet bitprophet added a commit that closed this pull request Aug 6, 2014
@bitprophet bitprophet Changelog, closes #1146 d782ce1
@bitprophet bitprophet closed this in d782ce1 Aug 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment