Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug where when mirror_local_mode lcd was not obeyed. Added tests... #1146

Closed
wants to merge 2 commits into from

Conversation

@atleta
Copy link

@atleta atleta commented Jun 18, 2014

Fixed the bug (one liner) and created tests that do break without applying the fix and do pass with the fix. Testing all the four scenarios (with and without jinja, with and without mirroring local mode).

@collinanderson
Copy link

@collinanderson collinanderson commented Jun 26, 2014

You could use contextlib.nested() on your with statement to add python 2.6 support.

https://docs.python.org/2/library/contextlib.html#contextlib.nested

@atleta
Copy link
Author

@atleta atleta commented Jun 26, 2014

Yep, already found out about the bug, but haven't pushed yet. As contextlib.nested is deprecated in 2.7 I used two nested with statements. Is that OK with you?

@atleta
Copy link
Author

@atleta atleta commented Jun 26, 2014

So I updated the pull request and now build passes.

@atleta
Copy link
Author

@atleta atleta commented Jul 19, 2014

Any updates on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants